LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Nadia.Derbey@bull.net To: linux-kernel@vger.kernel.org, y-goto@jp.fujitsu.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, containers@lists.linux-foundation.org, matthltc@us.ibm.com, cmm@us.ibm.com, Nadia Derbey <Nadia.Derbey@bull.net> Subject: [PATCH 2/8] Scaling msgmni to the number of ipc namespaces Date: Mon, 11 Feb 2008 15:16:48 +0100 [thread overview] Message-ID: <20080211141813.814567000@bull.net> (raw) In-Reply-To: 20080211141646.948191000@bull.net [-- Attachment #1: ipc_scale_msgmni_with_namespaces.patch --] [-- Type: text/plain, Size: 3131 bytes --] [PATCH 02/08] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net> --- include/linux/ipc_namespace.h | 1 + ipc/msg.c | 10 +++++++--- ipc/namespace.c | 3 +++ ipc/util.c | 3 +++ 4 files changed, 14 insertions(+), 3 deletions(-) Index: linux-2.6.24-mm1/include/linux/ipc_namespace.h =================================================================== --- linux-2.6.24-mm1.orig/include/linux/ipc_namespace.h 2008-02-07 15:00:43.000000000 +0100 +++ linux-2.6.24-mm1/include/linux/ipc_namespace.h 2008-02-07 15:26:53.000000000 +0100 @@ -33,6 +33,7 @@ struct ipc_namespace { }; extern struct ipc_namespace init_ipc_ns; +extern atomic_t nr_ipc_ns; #ifdef CONFIG_SYSVIPC #define INIT_IPC_NS(ns) .ns = &init_ipc_ns, Index: linux-2.6.24-mm1/ipc/util.c =================================================================== --- linux-2.6.24-mm1.orig/ipc/util.c 2008-02-07 13:41:07.000000000 +0100 +++ linux-2.6.24-mm1/ipc/util.c 2008-02-07 15:36:22.000000000 +0100 @@ -52,6 +52,9 @@ struct ipc_namespace init_ipc_ns = { }, }; +atomic_t nr_ipc_ns = ATOMIC_INIT(1); + + /** * ipc_init - initialise IPC subsystem * Index: linux-2.6.24-mm1/ipc/namespace.c =================================================================== --- linux-2.6.24-mm1.orig/ipc/namespace.c 2008-02-07 13:41:07.000000000 +0100 +++ linux-2.6.24-mm1/ipc/namespace.c 2008-02-07 15:40:19.000000000 +0100 @@ -20,6 +20,8 @@ static struct ipc_namespace *clone_ipc_n if (ns == NULL) return ERR_PTR(-ENOMEM); + atomic_inc(&nr_ipc_ns); + sem_init_ns(ns); msg_init_ns(ns); shm_init_ns(ns); @@ -83,4 +85,5 @@ void free_ipc_ns(struct kref *kref) msg_exit_ns(ns); shm_exit_ns(ns); kfree(ns); + atomic_dec(&nr_ipc_ns); } Index: linux-2.6.24-mm1/ipc/msg.c =================================================================== --- linux-2.6.24-mm1.orig/ipc/msg.c 2008-02-07 15:24:19.000000000 +0100 +++ linux-2.6.24-mm1/ipc/msg.c 2008-02-07 15:43:51.000000000 +0100 @@ -82,24 +82,28 @@ static int sysvipc_msg_proc_show(struct /* * Scale msgmni with the available lowmem size: the memory dedicated to msg * queues should occupy at most 1/MSG_MEM_SCALE of lowmem. - * This should be done staying within the (MSGMNI , IPCMNI) range. + * Also take into account the number of nsproxies created so far. + * This should be done staying within the (MSGMNI , IPCMNI/nr_ipc_ns) range. */ static void recompute_msgmni(struct ipc_namespace *ns) { struct sysinfo i; unsigned long allowed; + int nb_ns; si_meminfo(&i); allowed = (((i.totalram - i.totalhigh) / MSG_MEM_SCALE) * i.mem_unit) / MSGMNB; + nb_ns = atomic_read(&nr_ipc_ns); + allowed /= nb_ns; if (allowed < MSGMNI) { ns->msg_ctlmni = MSGMNI; goto out_callback; } - if (allowed > IPCMNI) { - ns->msg_ctlmni = IPCMNI; + if (allowed > IPCMNI / nb_ns) { + ns->msg_ctlmni = IPCMNI / nb_ns; goto out_callback; } --
next prev parent reply other threads:[~2008-02-11 14:20 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-11 14:16 [PATCH 0/8] Change default MSGMNI tunable to scale with lowmem (v3) Nadia.Derbey 2008-02-11 14:16 ` [PATCH 1/8] Scaling msgmni to the amount of lowmem Nadia.Derbey 2008-02-16 5:59 ` Andrew Morton 2008-02-18 9:19 ` Nadia Derbey 2008-02-18 13:08 ` Nadia Derbey 2008-02-19 8:50 ` [LTP] " Subrata Modak 2008-02-19 17:16 ` Nadia Derbey 2008-02-19 22:16 ` Matt Helsley 2008-02-21 8:39 ` Nadia Derbey 2008-02-21 12:36 ` Nadia Derbey 2008-02-21 13:02 ` Nadia Derbey 2008-02-21 13:39 ` Subrata Modak 2008-02-22 6:25 ` Nadia Derbey 2008-02-22 8:41 ` Subrata Modak 2008-02-20 9:44 ` Subrata Modak 2008-04-29 20:28 ` Tony Luck 2008-05-05 8:45 ` Nadia Derbey 2008-05-06 16:42 ` Luck, Tony 2008-05-06 18:05 ` Serge E. Hallyn 2008-05-07 5:37 ` Nadia Derbey 2008-05-07 13:17 ` Serge E. Hallyn 2008-05-07 18:12 ` Matt Helsley 2008-05-07 5:13 ` Nadia Derbey 2008-02-11 14:16 ` Nadia.Derbey [this message] 2008-02-11 14:16 ` [PATCH 3/8] Defining the slab_memory_callback priority as a constant Nadia.Derbey 2008-02-11 14:16 ` [PATCH 4/8] Recomputing msgmni on memory add / remove Nadia.Derbey 2008-02-11 14:16 ` [PATCH 5/8] Invoke the ipcns notifier chain as a work item Nadia.Derbey 2008-02-11 14:16 ` [PATCH 6/8] Recomputing msgmni on ipc namespace creation/removal Nadia.Derbey 2008-02-11 14:16 ` [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user Nadia.Derbey 2008-02-11 20:24 ` Andrew Morton 2008-02-12 9:32 ` Nadia Derbey 2008-02-12 9:44 ` Andrew Morton 2008-02-12 15:15 ` Nadia Derbey 2008-02-12 19:44 ` Andrew Morton 2008-02-14 11:47 ` Nadia Derbey 2008-02-12 9:45 ` Nadia Derbey 2008-02-11 14:16 ` [PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative Nadia.Derbey 2008-02-11 20:27 ` Andrew Morton 2008-02-12 11:38 ` Nadia Derbey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080211141813.814567000@bull.net \ --to=nadia.derbey@bull.net \ --cc=akpm@linux-foundation.org \ --cc=cmm@us.ibm.com \ --cc=containers@lists.linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=matthltc@us.ibm.com \ --cc=y-goto@jp.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).