LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nadia.Derbey@bull.net
To: linux-kernel@vger.kernel.org, y-goto@jp.fujitsu.com,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, containers@lists.linux-foundation.org,
matthltc@us.ibm.com, cmm@us.ibm.com,
Nadia Derbey <Nadia.Derbey@bull.net>
Subject: [PATCH 5/8] Invoke the ipcns notifier chain as a work item
Date: Mon, 11 Feb 2008 15:16:51 +0100 [thread overview]
Message-ID: <20080211141815.219468000@bull.net> (raw)
In-Reply-To: <20080211141646.948191000@bull.net>
[-- Attachment #1: ipc_ipcns_notification_workqueue.patch --]
[-- Type: text/plain, Size: 1581 bytes --]
[PATCH 05/08]
This patch makes the memory hotplug chain's mutex held for a shorter time:
when memory is offlined or onlined a work item is added to the global
workqueue.
When the work item is run, it notifies the ipcns notifier chain with the
IPCNS_MEMCHANGED event.
Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
---
ipc/util.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: linux-2.6.24-mm1/ipc/util.c
===================================================================
--- linux-2.6.24-mm1.orig/ipc/util.c 2008-02-08 08:15:35.000000000 +0100
+++ linux-2.6.24-mm1/ipc/util.c 2008-02-08 14:14:03.000000000 +0100
@@ -58,6 +58,14 @@ atomic_t nr_ipc_ns = ATOMIC_INIT(1);
#ifdef CONFIG_MEMORY_HOTPLUG
+static void ipc_memory_notifier(struct work_struct *work)
+{
+ ipcns_notify(IPCNS_MEMCHANGED);
+}
+
+static DECLARE_WORK(ipc_memory_wq, ipc_memory_notifier);
+
+
static int ipc_memory_callback(struct notifier_block *self,
unsigned long action, void *arg)
{
@@ -67,8 +75,13 @@ static int ipc_memory_callback(struct no
/*
* This is done by invoking the ipcns notifier chain with the
* IPC_MEMCHANGED event.
+ * In order not to keep the lock on the hotplug memory chain
+ * for too long, queue a work item that will, when waken up,
+ * activate the ipcns notification chain.
+ * No need to keep several ipc work items on the queue.
*/
- ipcns_notify(IPCNS_MEMCHANGED);
+ if (!work_pending(&ipc_memory_wq))
+ schedule_work(&ipc_memory_wq);
break;
case MEM_GOING_ONLINE:
case MEM_GOING_OFFLINE:
--
next prev parent reply other threads:[~2008-02-11 14:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 14:16 [PATCH 0/8] Change default MSGMNI tunable to scale with lowmem (v3) Nadia.Derbey
2008-02-11 14:16 ` [PATCH 1/8] Scaling msgmni to the amount of lowmem Nadia.Derbey
2008-02-16 5:59 ` Andrew Morton
2008-02-18 9:19 ` Nadia Derbey
2008-02-18 13:08 ` Nadia Derbey
2008-02-19 8:50 ` [LTP] " Subrata Modak
2008-02-19 17:16 ` Nadia Derbey
2008-02-19 22:16 ` Matt Helsley
2008-02-21 8:39 ` Nadia Derbey
2008-02-21 12:36 ` Nadia Derbey
2008-02-21 13:02 ` Nadia Derbey
2008-02-21 13:39 ` Subrata Modak
2008-02-22 6:25 ` Nadia Derbey
2008-02-22 8:41 ` Subrata Modak
2008-02-20 9:44 ` Subrata Modak
2008-04-29 20:28 ` Tony Luck
2008-05-05 8:45 ` Nadia Derbey
2008-05-06 16:42 ` Luck, Tony
2008-05-06 18:05 ` Serge E. Hallyn
2008-05-07 5:37 ` Nadia Derbey
2008-05-07 13:17 ` Serge E. Hallyn
2008-05-07 18:12 ` Matt Helsley
2008-05-07 5:13 ` Nadia Derbey
2008-02-11 14:16 ` [PATCH 2/8] Scaling msgmni to the number of ipc namespaces Nadia.Derbey
2008-02-11 14:16 ` [PATCH 3/8] Defining the slab_memory_callback priority as a constant Nadia.Derbey
2008-02-11 14:16 ` [PATCH 4/8] Recomputing msgmni on memory add / remove Nadia.Derbey
2008-02-11 14:16 ` Nadia.Derbey [this message]
2008-02-11 14:16 ` [PATCH 6/8] Recomputing msgmni on ipc namespace creation/removal Nadia.Derbey
2008-02-11 14:16 ` [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user Nadia.Derbey
2008-02-11 20:24 ` Andrew Morton
2008-02-12 9:32 ` Nadia Derbey
2008-02-12 9:44 ` Andrew Morton
2008-02-12 15:15 ` Nadia Derbey
2008-02-12 19:44 ` Andrew Morton
2008-02-14 11:47 ` Nadia Derbey
2008-02-12 9:45 ` Nadia Derbey
2008-02-11 14:16 ` [PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative Nadia.Derbey
2008-02-11 20:27 ` Andrew Morton
2008-02-12 11:38 ` Nadia Derbey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211141815.219468000@bull.net \
--to=nadia.derbey@bull.net \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthltc@us.ibm.com \
--cc=y-goto@jp.fujitsu.com \
--subject='Re: [PATCH 5/8] Invoke the ipcns notifier chain as a work item' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).