LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eugene Teo <eugeneteo@kernel.sg>
To: KOSAKI Motohiro <m-kosaki@ceres.dti.ne.jp>
Cc: linux-kernel@vger.kernel.org, Miklos Szeredi <mszeredi@suse.cz>
Subject: Re: [PATCH] proc: extend /proc/<pid>/fdinfo/<fd>
Date: Mon, 11 Feb 2008 22:31:14 +0800	[thread overview]
Message-ID: <20080211143114.GB3695@kernel.sg> (raw)
In-Reply-To: <2f11576a0802110220g459d7390je05bfec161e6768e@mail.gmail.com>

Hi Motohiro-san,

<quote sender="KOSAKI Motohiro">
> In general, I think this patch isn't wrong idea.
> but it shuld be brush up more, may be.

Thanks.

> > kerndev: ~/code/kernel# cat /proc/`pgrep pickup`/fdinfo/6
> > mode:   0622
> 
> I think this is inode attribute, but not fd attribute.

Yes, it is an inode attribute.

> > dev:    253,0
> > ino:    21463057
> 
> may be useful, agreed with you :)

Thanks.

> > uid:    89
> > gid:    89
> > rdev:   0,0
> > pos:    0
> > flags:  04002 FD_CLOEXEC # if close-on-exec flag is set
> 
> agreed with Miklos's opinion.
> 
> > path:   /var/spool/postfix/public/pickup
> 
> may be, we shold think namespace..

Besides readlink, this info can be gathered by running:
ls -laF /proc/<pid>/fd/<fd>

So, I agree with Miklo's opinion that we can omit this in the output.

> > You can also use this to find out more information about locked open files:
> 
> is your requirement only fd -> ino pick up?

Not only this, but it is useful to know quickly if the open file descriptor
has a close-on-exec flag set.

Thanks,
Eugene

      reply	other threads:[~2008-02-11 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 12:01 Eugene Teo
2008-02-11  9:08 ` Miklos Szeredi
2008-02-11 14:23   ` Eugene Teo
2008-02-11 10:20 ` KOSAKI Motohiro
2008-02-11 14:31   ` Eugene Teo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080211143114.GB3695@kernel.sg \
    --to=eugeneteo@kernel.sg \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-kosaki@ceres.dti.ne.jp \
    --cc=mszeredi@suse.cz \
    --subject='Re: [PATCH] proc: extend /proc/<pid>/fdinfo/<fd>' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).