LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: Olof Johansson <>
Subject: Re: [PATCH] Execute tasklets in the same order they were queued
Date: Mon, 11 Feb 2008 14:49:27 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 11 Feb 2008 16:28:13 -0600
Olof Johansson <> wrote:

> I noticed this when looking at an openswan issue. Openswan (ab?)uses
> the tasklet API to defer processing of packets in some situations,
> with one packet per tasklet_action(). I started noticing sequences of
> reverse-ordered sequence numbers coming over the wire, since new tasklets
> are always queued at the head of the list but processed sequentially.
> Convert it to instead append new entries to the tail of the list. As an
> extra bonus, the splicing code in takeover_tasklets() no longer has to
> iterate over the list.

hm, I'd have thought that this would already have caused problems in
networking.  And perhaps this change might have effects on networking too?

Probably it won't have _much_ effect on networking because networking
probably isn't queueing one tasklet per packet(!) but perhaps with bonded
channels or something like that?

  reply	other threads:[~2008-02-11 22:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 22:28 Olof Johansson
2008-02-11 22:49 ` Andrew Morton [this message]
2008-02-12 21:55 ` Andrew Morton
2008-02-12 22:06   ` [PATCH v2] " Olof Johansson
2008-02-12 22:19     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH] Execute tasklets in the same order they were queued' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).