LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* 2.6.25-rc1 regression - suspend to ram
@ 2008-02-11 22:58 Lukas Hejtmanek
  2008-02-11 23:10 ` R. J. Wysocki
  2008-02-11 23:16 ` Jesse Barnes
  0 siblings, 2 replies; 6+ messages in thread
From: Lukas Hejtmanek @ 2008-02-11 22:58 UTC (permalink / raw)
  To: linux-kernel

Hello,

2.6.25-rc1 takes really long time till it suspends (about 30-40secs, used to
be about 5 secs at all) and it is resuming about few minutes.  While resuming,
capslock toggles the capslock led but with few secs delay.

2.6.24-git15 was OK. 2.6.24 is OK.

I have Lenovo ThinkPad T61.

-- 
Lukáš Hejtmánek

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.25-rc1 regression - suspend to ram
  2008-02-11 22:58 2.6.25-rc1 regression - suspend to ram Lukas Hejtmanek
@ 2008-02-11 23:10 ` R. J. Wysocki
  2008-02-11 23:22   ` Venki Pallipadi
  2008-02-11 23:16 ` Jesse Barnes
  1 sibling, 1 reply; 6+ messages in thread
From: R. J. Wysocki @ 2008-02-11 23:10 UTC (permalink / raw)
  To: Lukas Hejtmanek
  Cc: linux-kernel, ACPI Devel Maling List, Len Brown, venkatesh.pallipadi

On Monday, 11 of February 2008, Lukas Hejtmanek wrote:
> Hello,

Hi,
 
> 2.6.25-rc1 takes really long time till it suspends (about 30-40secs, used to
> be about 5 secs at all) and it is resuming about few minutes.  While resuming,
> capslock toggles the capslock led but with few secs delay.
> 
> 2.6.24-git15 was OK. 2.6.24 is OK.
> 
> I have Lenovo ThinkPad T61.

If you have CONFIG_CPU_IDLE set, please try to boot with idle=poll and see if
that helps.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.25-rc1 regression - suspend to ram
  2008-02-11 22:58 2.6.25-rc1 regression - suspend to ram Lukas Hejtmanek
  2008-02-11 23:10 ` R. J. Wysocki
@ 2008-02-11 23:16 ` Jesse Barnes
  1 sibling, 0 replies; 6+ messages in thread
From: Jesse Barnes @ 2008-02-11 23:16 UTC (permalink / raw)
  To: Lukas Hejtmanek; +Cc: linux-kernel

On Monday, February 11, 2008 2:58 pm Lukas Hejtmanek wrote:
> Hello,
>
> 2.6.25-rc1 takes really long time till it suspends (about 30-40secs, used
> to be about 5 secs at all) and it is resuming about few minutes.  While
> resuming, capslock toggles the capslock led but with few secs delay.
>
> 2.6.24-git15 was OK. 2.6.24 is OK.
>
> I have Lenovo ThinkPad T61.

Oh, you're lucky, I couldn't get my T61 to suspend at all with 2.6.25-rc1...  

Len found that it'll work again with idle=poll, but that'll cost you a lot of 
battery life...

Oh and make sure you have i915 loaded before you suspend if you want your text 
console to come back.

Jesse

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.25-rc1 regression - suspend to ram
  2008-02-11 23:10 ` R. J. Wysocki
@ 2008-02-11 23:22   ` Venki Pallipadi
  2008-02-11 23:32     ` Jesse Barnes
  2008-02-12 17:14     ` Lukas Hejtmanek
  0 siblings, 2 replies; 6+ messages in thread
From: Venki Pallipadi @ 2008-02-11 23:22 UTC (permalink / raw)
  To: R. J. Wysocki
  Cc: Lukas Hejtmanek, linux-kernel, ACPI Devel Maling List, Len Brown,
	venkatesh.pallipadi

On Tue, Feb 12, 2008 at 12:10:54AM +0100, R. J. Wysocki wrote:
> On Monday, 11 of February 2008, Lukas Hejtmanek wrote:
> > Hello,
> 
> Hi,
>  
> > 2.6.25-rc1 takes really long time till it suspends (about 30-40secs, used to
> > be about 5 secs at all) and it is resuming about few minutes.  While resuming,
> > capslock toggles the capslock led but with few secs delay.
> > 
> > 2.6.24-git15 was OK. 2.6.24 is OK.
> > 
> > I have Lenovo ThinkPad T61.
> 
> If you have CONFIG_CPU_IDLE set, please try to boot with idle=poll and see if
> that helps.
> 

Just sent this patch to fix a regression in acpi processor_idle.c on another
thread. Can you try the patch below and check whether that helps.

Thanks,
Venki


Earlier patch (bc71bec91f9875ef825d12104acf3bf4ca215fa4) broke
suspend resume on many laptops. The problem was reported by
Carlos R. Mafra and Calvin Walton, who bisected the issue to above patch.

The problem was because, C2 and C3 code were calling acpi_idle_enter_c1
directly, with C2 or C3 as state parameter, while suspend/resume was in
progress. The patch bc71bec started making use of that state information,
assuming that it would always be referring to C1 state. This caused the
problem with suspend-resume as we ended up using C2/C3 state indirectly.

Fix this by adding acpi_idle_suspend check in enter_c1.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

Index: linux-2.6.25-rc1/drivers/acpi/processor_idle.c
===================================================================
--- linux-2.6.25-rc1.orig/drivers/acpi/processor_idle.c
+++ linux-2.6.25-rc1/drivers/acpi/processor_idle.c
@@ -1420,6 +1420,14 @@ static int acpi_idle_enter_c1(struct cpu
 		return 0;
 
 	local_irq_disable();
+
+	/* Do not access any ACPI IO ports in suspend path */
+	if (acpi_idle_suspend) {
+		acpi_safe_halt();
+		local_irq_enable();
+		return 0;
+	}
+
 	if (pr->flags.bm_check)
 		acpi_idle_update_bm_rld(pr, cx);
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.25-rc1 regression - suspend to ram
  2008-02-11 23:22   ` Venki Pallipadi
@ 2008-02-11 23:32     ` Jesse Barnes
  2008-02-12 17:14     ` Lukas Hejtmanek
  1 sibling, 0 replies; 6+ messages in thread
From: Jesse Barnes @ 2008-02-11 23:32 UTC (permalink / raw)
  To: Venki Pallipadi
  Cc: R. J. Wysocki, Lukas Hejtmanek, linux-kernel,
	ACPI Devel Maling List, Len Brown

On Monday, February 11, 2008 3:22 pm Venki Pallipadi wrote:
> On Tue, Feb 12, 2008 at 12:10:54AM +0100, R. J. Wysocki wrote:
> > On Monday, 11 of February 2008, Lukas Hejtmanek wrote:
> > > Hello,
> >
> > Hi,
> >
> > > 2.6.25-rc1 takes really long time till it suspends (about 30-40secs,
> > > used to be about 5 secs at all) and it is resuming about few minutes. 
> > > While resuming, capslock toggles the capslock led but with few secs
> > > delay.
> > >
> > > 2.6.24-git15 was OK. 2.6.24 is OK.
> > >
> > > I have Lenovo ThinkPad T61.
> >
> > If you have CONFIG_CPU_IDLE set, please try to boot with idle=poll and
> > see if that helps.
>
> Just sent this patch to fix a regression in acpi processor_idle.c on
> another thread. Can you try the patch below and check whether that helps.

Excellent, that patch makes things work for me (including console restore).  
Thanks a lot Venki.

Jesse

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.25-rc1 regression - suspend to ram
  2008-02-11 23:22   ` Venki Pallipadi
  2008-02-11 23:32     ` Jesse Barnes
@ 2008-02-12 17:14     ` Lukas Hejtmanek
  1 sibling, 0 replies; 6+ messages in thread
From: Lukas Hejtmanek @ 2008-02-12 17:14 UTC (permalink / raw)
  To: Venki Pallipadi
  Cc: R. J. Wysocki, linux-kernel, ACPI Devel Maling List, Len Brown

On Mon, Feb 11, 2008 at 03:22:13PM -0800, Venki Pallipadi wrote:
> Just sent this patch to fix a regression in acpi processor_idle.c on another
> thread. Can you try the patch below and check whether that helps.

Yeah, it seems that it fixed suspend troubles.

-- 
Lukáš Hejtmánek

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-02-12 17:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-11 22:58 2.6.25-rc1 regression - suspend to ram Lukas Hejtmanek
2008-02-11 23:10 ` R. J. Wysocki
2008-02-11 23:22   ` Venki Pallipadi
2008-02-11 23:32     ` Jesse Barnes
2008-02-12 17:14     ` Lukas Hejtmanek
2008-02-11 23:16 ` Jesse Barnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).