LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] /proc/pid/pagemap: fix PM_SPECIAL macro
@ 2008-02-11 16:53 Hans Rosenfeld
  0 siblings, 0 replies; only message in thread
From: Hans Rosenfeld @ 2008-02-11 16:53 UTC (permalink / raw)
  To: Matt Mackall; +Cc: linux-kernel

There seems to be a bug in the PM_SPECIAL macro for /proc/pid/pagemap.
I think masking out those other bits makes more sense then setting all
those mask bits.


Signed-off-by: Hans Rosenfeld <Hans.Rosenfeld@amd.com>

---
 fs/proc/task_mmu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index ae4d3f2..2e8a6fa 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -531,7 +531,7 @@ struct pagemapread {
 #define PM_RESERVED_BITS    3
 #define PM_RESERVED_OFFSET  (64 - PM_RESERVED_BITS)
 #define PM_RESERVED_MASK    (((1LL<<PM_RESERVED_BITS)-1) << PM_RESERVED_OFFSET)
-#define PM_SPECIAL(nr)      (((nr) << PM_RESERVED_OFFSET) | PM_RESERVED_MASK)
+#define PM_SPECIAL(nr)      (((nr) << PM_RESERVED_OFFSET) & PM_RESERVED_MASK)
 #define PM_NOT_PRESENT      PM_SPECIAL(1LL)
 #define PM_SWAP             PM_SPECIAL(2LL)
 #define PM_END_OF_BUFFER    1
-- 
1.5.3.7



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-11 16:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-11 16:53 [PATCH] /proc/pid/pagemap: fix PM_SPECIAL macro Hans Rosenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).