LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: chris.mason@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
btrfs-devel@oss.oracle.com
Subject: CRC32C big endian bugs...
Date: Tue, 12 Feb 2008 01:23:36 -0800 (PST) [thread overview]
Message-ID: <20080212.012336.241084860.davem@davemloft.net> (raw)
In-Reply-To: <200802061200.14690.chris.mason@oracle.com>
The CRC32C implementation in the btrfs progs is different from the one
in the kernel, so obviously nothing can possibly work on big-endian.
This is getting less and less fun by the minute, I simply wanted to
test btrfs on Niagara :-/
Here is a patch to fix that:
--- vanilla/btrfs-progs-0.12/crc32c.c 2008-02-06 08:37:45.000000000 -0800
+++ btrfs-progs-0.12/crc32c.c 2008-02-12 01:19:33.000000000 -0800
@@ -91,13 +91,11 @@ static const u32 crc32c_table[256] = {
* crc using table.
*/
-u32 crc32c_le(u32 seed, unsigned char const *data, size_t length)
+u32 crc32c_le(u32 crc, unsigned char const *data, size_t length)
{
- u32 crc = (__force __u32)(cpu_to_le32(seed));
-
while (length--)
crc =
crc32c_table[(crc ^ *data++) & 0xFFL] ^ (crc >> 8);
- return le32_to_cpu((__force __le32)crc);
+ return crc;
}
next prev parent reply other threads:[~2008-02-12 9:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 17:00 [ANNOUNCE] Btrfs v0.12 released Chris Mason
2008-02-11 1:12 ` David Miller
2008-02-11 13:42 ` Chris Mason
2008-02-12 6:43 ` David Miller
2008-02-12 13:43 ` Chris Mason
2008-02-12 7:21 ` BTRFS partition usage David Miller
2008-02-12 8:11 ` David Miller
2008-02-12 13:49 ` Chris Mason
2008-02-12 14:00 ` Jan Engelhardt
2008-02-12 14:08 ` Chris Mason
2008-02-12 14:21 ` Jan Engelhardt
2008-02-12 14:35 ` Chris Mason
2008-02-12 15:04 ` Jan Engelhardt
2008-02-12 16:17 ` Chris Mason
2008-02-12 23:38 ` David Miller
2008-02-12 23:42 ` Jan Engelhardt
2008-02-13 1:09 ` David Miller
2008-02-13 1:22 ` Rene Herman
2008-02-12 23:35 ` David Miller
2008-02-13 7:02 ` Christoph Hellwig
2008-02-12 23:34 ` David Miller
2008-02-12 23:33 ` David Miller
2008-02-13 2:10 ` Jeff Garzik
2008-02-14 0:51 ` Szabolcs Szakacsits
2008-02-12 23:26 ` David Miller
2008-02-12 23:39 ` Jan Engelhardt
2008-02-13 1:08 ` David Miller
2008-02-13 1:25 ` Bryan Henderson
2008-02-12 23:28 ` David Miller
2008-02-13 0:45 ` Theodore Tso
2008-02-12 20:50 ` David Miller
2008-02-12 9:23 ` David Miller [this message]
2008-02-12 21:55 ` BTRFS only works with PAGE_SIZE <= 4K David Miller
2008-02-12 22:03 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212.012336.241084860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=btrfs-devel@oss.oracle.com \
--cc=chris.mason@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: CRC32C big endian bugs...' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).