LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ide: Add missing base addresses for falconide and macide
@ 2008-02-11 21:34 Geert Uytterhoeven
2008-02-12 0:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2008-02-11 21:34 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Michael Schmitz, linux-ide, Linux/m68k, Linux Kernel Development
commit 29dd59755a849cc6475faa6a75f3b804e23a6fc2 ("ide: remove ide_setup_ports")
forgot to take into account the base addresses for the CONTROL registers for
falconide and macide, as pointed out by Michael Schmitz.
Falconide was tested on Aranym.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Schmitz <schmitz@debian.org>
---
drivers/ide/legacy/falconide.c | 2 +-
drivers/ide/legacy/macide.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/ide/legacy/falconide.c
+++ b/drivers/ide/legacy/falconide.c
@@ -54,7 +54,7 @@ static void __init falconide_setup_ports
for (i = 1; i < 8; i++)
hw->io_ports[i] = ATA_HD_BASE + 1 + i * 4;
- hw->io_ports[IDE_CONTROL_OFFSET] = ATA_HD_CONTROL;
+ hw->io_ports[IDE_CONTROL_OFFSET] = ATA_HD_BASE + ATA_HD_CONTROL;
hw->irq = IRQ_MFP_IDE;
hw->ack_intr = NULL;
--- a/drivers/ide/legacy/macide.c
+++ b/drivers/ide/legacy/macide.c
@@ -74,7 +74,7 @@ static void __init macide_setup_ports(hw
for (i = 0; i < 8; i++)
hw->io_ports[i] = base + i * 4;
- hw->io_ports[IDE_CONTROL_OFFSET] = IDE_CONTROL;
+ hw->io_ports[IDE_CONTROL_OFFSET] = base + IDE_CONTROL;
hw->irq = irq;
hw->ack_intr = ack_intr;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ide: Add missing base addresses for falconide and macide
2008-02-11 21:34 [PATCH] ide: Add missing base addresses for falconide and macide Geert Uytterhoeven
@ 2008-02-12 0:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-12 0:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Michael Schmitz, linux-ide, Linux/m68k, Linux Kernel Development
On Monday 11 February 2008, Geert Uytterhoeven wrote:
> commit 29dd59755a849cc6475faa6a75f3b804e23a6fc2 ("ide: remove ide_setup_ports")
> forgot to take into account the base addresses for the CONTROL registers for
> falconide and macide, as pointed out by Michael Schmitz.
>
> Falconide was tested on Aranym.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Michael Schmitz <schmitz@debian.org>
Thanks! Applied.
[ this patch was a missing link to (hopefully) bring the number of open
2.6.25 IDE regressions down to _zero_ ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-12 0:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-11 21:34 [PATCH] ide: Add missing base addresses for falconide and macide Geert Uytterhoeven
2008-02-12 0:15 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).