LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: Roland Dreier <rdreier@cisco.com>
Cc: Olof Johansson <olof@lixom.net>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	general@lists.openfabrics.org, linux-kernel@vger.kernel.org,
	tziporet@mellanox.co.il
Subject: Re: [PATCH] mlx4: fix build break
Date: Tue, 12 Feb 2008 09:43:33 +0200	[thread overview]
Message-ID: <200802120943.34388.jackm@dev.mellanox.co.il> (raw)
In-Reply-To: <adaodanxhlb.fsf@cisco.com>

On Tuesday 12 February 2008 00:18, Roland Dreier wrote:
> Thanks, applied.
> 
> Jack, I thought you guys tested the build on powerpc.  How did this
> sneak through?
> 
It did not sneak through, because the problem does not exist in the OFED git.

The following commit was performed to
 git://git.openfabrics.org/ofed_1_3/linux-2.6.git
on Sept 25, 2007:
=======================================
commit 4a5709b81dfd249c98271801ddc01decb7acd466
Author: Eli Cohen <eli@mellanox.co.il>
Date:   Tue Sep 25 12:41:30 2007 +0200

    add missing include file. ia64 requires it.

    Signed-off-by: Eli Cohen <eli@mellanox.co.il>

diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c
index f8d63d3..704a56b 100644
--- a/drivers/net/mlx4/alloc.c
+++ b/drivers/net/mlx4/alloc.c
@@ -34,6 +34,7 @@
 #include <linux/slab.h>
 #include <linux/bitmap.h>
 #include <linux/dma-mapping.h>
+#include <linux/vmalloc.h>

 #include "mlx4.h"
========================================

I guess this just fell through the cracks with regard to posting it to the list.
Sorry about that.

- Jack

      parent reply	other threads:[~2008-02-12  7:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 23:16 [GIT PULL] please pull infiniband.git Roland Dreier
2008-02-11  2:22 ` [PATCH] mlx4: fix build break Olof Johansson
2008-02-11 22:18   ` Roland Dreier
2008-02-12  5:30     ` [ofa-general] " Tziporet Koren
2008-02-12  7:43     ` Jack Morgenstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802120943.34388.jackm@dev.mellanox.co.il \
    --to=jackm@dev.mellanox.co.il \
    --cc=akpm@linux-foundation.org \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rdreier@cisco.com \
    --cc=torvalds@linux-foundation.org \
    --cc=tziporet@mellanox.co.il \
    --subject='Re: [PATCH] mlx4: fix build break' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).