LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Oleg Verych <olecom@flower.upol.cz>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] kbuild: fix make V=1
Date: Tue, 12 Feb 2008 10:07:49 -0500	[thread overview]
Message-ID: <200802121007.50638.vapier@gentoo.org> (raw)
In-Reply-To: <20080212092504.GI24008@flower.upol.cz>

[-- Attachment #1: Type: text/plain, Size: 2222 bytes --]

On Tuesday 12 February 2008, Oleg Verych wrote:
> On Tue, Feb 12, 2008 at 09:56:05AM +0100, Sam Ravnborg wrote:
> > On Tue, Feb 12, 2008 at 12:38:24AM +0100, Oleg Verych wrote:
> > > * Date: Mon, 11 Feb 2008 17:47:09 +0100
> > > []
> > >
> > > > Mike spotted another missing thing from his initial
> > > > patch so I folded it into the fix and pushed out
> > > > a new kbuild.git tree.
> > > >
> > > > See updated patch below.
> > >
> > > Sam, do you agree my fix was more reliable (yea, not only efficient:)?
> >
> > You more or less just reverted the original patch - so it was obviously
> > more reliable than introducing new stuff as the fix did.
> > But we are at -r1 so I prefer to get the inteded behaviour
> > and not the minmal fix.
>
> Processing below changes arguments, not semantics of generated shell
> code. And IMHO this is more reliable way of doing things. If one really
> wants silence without commonly accepted ">/dev/null 2>&1" practice, then
> choose portable "-n" argument for `echo`.
>
> - quiet_chk_filechk = echo '  CHK     $@'
> -silent_chk_filechk = :
> - quiet_upd_filechk = echo '  UPD     $@'
> -silent_upd_filechk = :
> +quiet_chk_filechk = '  CHK     $@'
> +quiet_upd_filechk = '  UPD     $@'
> +
>  define filechk
>  	$(Q)set -e;				\
> -	$($(quiet)chk_filechk);			\
> +	echo $($(quiet)chk_filechk);		\
>  	mkdir -p $(dir $@);			\
>  	$(filechk_$(1)) < $< > $@.tmp;		\
>  	if [ -r $@ ] && cmp -s $@ $@.tmp; then	\
>  		rm -f $@.tmp;			\
>  	else					\
> -		$($(quiet)upd_filechk);		\
> +		echo $($(quiet)upd_filechk);	\
>  		mv -f $@.tmp $@;		\
>  	fi
>  endef

i dont see how yours is more efficient when it always runs echo.  nor does it 
give the same behavior ... your propposed change will echo blank lines in the 
silent mode which is incorrect.  it also does not seem to follow the standard 
convention of other kconfig commands that have quiet/silent prefixes ... such 
commands do not define arguments to an unknown program/function, nor do they 
add arbitrary redirection which gets leads to confusion as to final 
expansion, they define the entire command.

what Sam posted (and what was merged) makes sense to me.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2008-02-12 15:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  0:44 Linux 2.6.25-rc1 Linus Torvalds
2008-02-11  1:36 ` Sergio Luis
2008-02-11  1:47 ` Linux 2.6.25-rc1 , syntax error near unexpected token `;' Mr. James W. Laferriere
2008-02-11  7:02   ` Ray Lee
2008-02-11 13:29     ` [patch] " Oleg Verych
2008-02-11 13:26   ` Sam Ravnborg
2008-02-12  3:37     ` Mr. James W. Laferriere
2008-02-11  3:14 ` Linux 2.6.25-rc1 Gene Heskett
2008-02-11  7:39 ` Brice Goglin
2008-02-11 15:16   ` Arjan van de Ven
2008-02-11 11:19 ` parisc - error: 'VMALLOC_START' undeclared Domenico Andreoli
2008-02-11 12:06   ` Adrian Bunk
2008-02-11 13:31 ` Linux 2.6.25-rc1 Sam Ravnborg
2008-02-11 16:17   ` Mike Frysinger
2008-02-11 16:47   ` [PATCH] kbuild: fix make V=1 Sam Ravnborg
2008-02-11 23:38     ` Oleg Verych
2008-02-12  8:56       ` Sam Ravnborg
2008-02-12  9:25         ` Oleg Verych
2008-02-12 15:07           ` Mike Frysinger [this message]
2008-02-12 15:49             ` Oleg Verych
2008-02-12 16:18               ` Mike Frysinger
2008-02-12 16:42                 ` Oleg Verych
2008-02-12 20:01           ` Sam Ravnborg
2008-02-11 21:46 ` Linux 2.6.25-rc1 Torsten Kaiser
2008-02-11 22:15   ` Andrew Morton
2008-02-11 22:48     ` Stefan Richter
2008-02-13 19:17     ` Torsten Kaiser
2008-02-12  8:18 ` [ata crash] " Ingo Molnar
2008-02-12 15:14   ` Arjan van de Ven
2008-02-13  9:01     ` Ingo Molnar
2008-02-13  9:20       ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Tejun Heo
2008-02-13  9:24         ` Ingo Molnar
2008-02-15 18:52         ` Jeff Garzik
2008-02-13  9:51   ` [ata crash] Re: Linux 2.6.25-rc1 Tejun Heo
2008-02-21  2:33     ` Tejun Heo
2008-02-21  7:12       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802121007.50638.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olecom@flower.upol.cz \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] kbuild: fix make V=1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).