LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: "Oleg Verych" <olecom@gmail.com>
Cc: "Oleg Verych" <olecom@flower.upol.cz>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] kbuild: fix make V=1
Date: Tue, 12 Feb 2008 11:18:10 -0500	[thread overview]
Message-ID: <200802121118.11312.vapier@gentoo.org> (raw)
In-Reply-To: <8499950a0802120749r33323a15k7cde80862ae26c3d@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2849 bytes --]

On Tuesday 12 February 2008, Oleg Verych wrote:
> On Feb 12, 2008 4:07 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> []
>
> > > - quiet_chk_filechk = echo '  CHK     $@'
> > > -silent_chk_filechk = :
> > > - quiet_upd_filechk = echo '  UPD     $@'
> > > -silent_upd_filechk = :
> > > +quiet_chk_filechk = '  CHK     $@'
> > > +quiet_upd_filechk = '  UPD     $@'
> > > +
> > >  define filechk
> > >       $(Q)set -e;                             \
> > > -     $($(quiet)chk_filechk);                 \
> > > +     echo $($(quiet)chk_filechk);            \
> > >       mkdir -p $(dir $@);                     \
> > >       $(filechk_$(1)) < $< > $@.tmp;          \
> > >       if [ -r $@ ] && cmp -s $@ $@.tmp; then  \
> > >               rm -f $@.tmp;                   \
> > >       else                                    \
> > > -             $($(quiet)upd_filechk);         \
> > > +             echo $($(quiet)upd_filechk);    \
> > >               mv -f $@.tmp $@;                \
> > >       fi
> > >  endef
> >
> > i dont see how yours is more efficient when it always runs echo.
>
> Oh, this? It's like doing syscall for every write to "/dev/null".

how is that relevant ?  there is no /dev/null redirection anywhere here

> > nor does it give the same behavior ... your propposed change will echo
> > blank lines in the silent mode which is incorrect.
>
> At least this will not crash, if you don't have some variable set.
>
> Efficiency there is lesser number of variables(-2 vs +2), that are copied
> for every make job, and are textually parsed and searched.

which is most likely less than executing `echo` everytime instead of ":"

> > it also does not seem to follow the standard convention of other
> > kconfig commands that have quiet/silent prefixes ... such commands do
> > not define arguments to an unknown program/function, nor do they add
> > arbitrary redirection which gets leads to confusion as to final
> > expansion, they define the entire command.
>
> Right. Seems like you are talking about "[quite_]cmd_*", which are
> commands. Here you've invented such rules for ordinary utility in
> `filechk`.

just like every other place in the tree.

> And by try they've failed due to mixing functionality 
> dependency on having arbitrary variable being set.

and by "arbitrary" you mean "like every other kconfig consumer".  sounds 
pretty arbitrary to me.

> Shell syntax tried to avoid this, but `make` syntax and ``convention''
> did a boom. Boom, where hacker's V=1 mode failed itself and failed to
> give a clue about problem (at least, when i saw Sam's message in
> linux-kbuild). Yea, `make` is not needed.

shell syntax is irrelevant.  a bug was introduced and it was fixed.  saying a 
bug existed is poor reasoning to introduce worse code.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2008-02-12 16:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  0:44 Linux 2.6.25-rc1 Linus Torvalds
2008-02-11  1:36 ` Sergio Luis
2008-02-11  1:47 ` Linux 2.6.25-rc1 , syntax error near unexpected token `;' Mr. James W. Laferriere
2008-02-11  7:02   ` Ray Lee
2008-02-11 13:29     ` [patch] " Oleg Verych
2008-02-11 13:26   ` Sam Ravnborg
2008-02-12  3:37     ` Mr. James W. Laferriere
2008-02-11  3:14 ` Linux 2.6.25-rc1 Gene Heskett
2008-02-11  7:39 ` Brice Goglin
2008-02-11 15:16   ` Arjan van de Ven
2008-02-11 11:19 ` parisc - error: 'VMALLOC_START' undeclared Domenico Andreoli
2008-02-11 12:06   ` Adrian Bunk
2008-02-11 13:31 ` Linux 2.6.25-rc1 Sam Ravnborg
2008-02-11 16:17   ` Mike Frysinger
2008-02-11 16:47   ` [PATCH] kbuild: fix make V=1 Sam Ravnborg
2008-02-11 23:38     ` Oleg Verych
2008-02-12  8:56       ` Sam Ravnborg
2008-02-12  9:25         ` Oleg Verych
2008-02-12 15:07           ` Mike Frysinger
2008-02-12 15:49             ` Oleg Verych
2008-02-12 16:18               ` Mike Frysinger [this message]
2008-02-12 16:42                 ` Oleg Verych
2008-02-12 20:01           ` Sam Ravnborg
2008-02-11 21:46 ` Linux 2.6.25-rc1 Torsten Kaiser
2008-02-11 22:15   ` Andrew Morton
2008-02-11 22:48     ` Stefan Richter
2008-02-13 19:17     ` Torsten Kaiser
2008-02-12  8:18 ` [ata crash] " Ingo Molnar
2008-02-12 15:14   ` Arjan van de Ven
2008-02-13  9:01     ` Ingo Molnar
2008-02-13  9:20       ` [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure Tejun Heo
2008-02-13  9:24         ` Ingo Molnar
2008-02-15 18:52         ` Jeff Garzik
2008-02-13  9:51   ` [ata crash] Re: Linux 2.6.25-rc1 Tejun Heo
2008-02-21  2:33     ` Tejun Heo
2008-02-21  7:12       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802121118.11312.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olecom@flower.upol.cz \
    --cc=olecom@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] kbuild: fix make V=1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).