LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Use ELF_CORE_EFLAGS for kcore ELF header flags.
@ 2008-02-12 13:34 Edgar E. Iglesias
  2008-02-14  0:40 ` Andrew Morton
  2008-02-14  1:36 ` Yoshinori Sato
  0 siblings, 2 replies; 5+ messages in thread
From: Edgar E. Iglesias @ 2008-02-12 13:34 UTC (permalink / raw)
  To: ysato, linux-kernel; +Cc: mikael.starvik

ELF_CORE_EFLAGS is already used by the binfmt_elf coredumper to set correct 
arch specific ELF header flags on coredumps. Use it for kcore aswell.
This corrects kcore files for the CRIS arch and I beleive it corrects 
ordinary coredumps for the H8/300.

Signed-off-by: Edgar E. Iglesias <edgar@axis.com>

---

diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index e78c81f..c2370c7 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -23,6 +23,10 @@
 
 #define CORE_STR "CORE"
 
+#ifndef ELF_CORE_EFLAGS
+#define ELF_CORE_EFLAGS	0
+#endif
+
 static int open_kcore(struct inode * inode, struct file * filp)
 {
 	return capable(CAP_SYS_RAWIO) ? 0 : -EPERM;
@@ -164,11 +168,7 @@ static void elf_kcore_store_hdr(char *bufp, int nphdr, int dataoff)
 	elf->e_entry	= 0;
 	elf->e_phoff	= sizeof(struct elfhdr);
 	elf->e_shoff	= 0;
-#if defined(CONFIG_H8300)
-	elf->e_flags	= ELF_FLAGS;
-#else
-	elf->e_flags	= 0;
-#endif
+	elf->e_flags	= ELF_CORE_EFLAGS;
 	elf->e_ehsize	= sizeof(struct elfhdr);
 	elf->e_phentsize= sizeof(struct elf_phdr);
 	elf->e_phnum	= nphdr;
diff --git a/include/asm-h8300/elf.h b/include/asm-h8300/elf.h
index 26bfc7e..806f20b 100644
--- a/include/asm-h8300/elf.h
+++ b/include/asm-h8300/elf.h
@@ -32,6 +32,8 @@ typedef unsigned long elf_fpregset_t;
 #define ELF_FLAGS       0x820000
 #endif
 
+#define ELF_CORE_EFLAGS ELF_FLAGS
+
 #define ELF_PLAT_INIT(_r)	_r->er1 = 0
 
 #define USE_ELF_CORE_DUMP

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-14  9:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-12 13:34 [PATCH] Use ELF_CORE_EFLAGS for kcore ELF header flags Edgar E. Iglesias
2008-02-14  0:40 ` Andrew Morton
2008-02-14  9:03   ` Edgar E. Iglesias
2008-02-14  1:36 ` Yoshinori Sato
2008-02-14  9:40   ` Edgar E. Iglesias

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).