LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
	"Mark M. Hoffman" <mhoffman@lightlink.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)
Date: Tue, 12 Feb 2008 07:27:15 -0800	[thread overview]
Message-ID: <20080212152715.GB19441@kroah.com> (raw)
In-Reply-To: <20080212092722.32c30eac@hyperion.delvare>

On Tue, Feb 12, 2008 at 09:27:22AM +0100, Jean Delvare wrote:
> Hi Yinghai,
> 
> On Mon, 11 Feb 2008 15:39:39 -0800, Yinghai Lu wrote:
> > On Feb 10, 2008 10:01 AM, Jean Delvare <khali@linux-fr.org> wrote:
> > > Yeah, I am an idiot. In 5b34dbcd88251508d02e48ad9b0f9b8232a13ee0 I
> > > introduced two new sysfs file groups but forgot to NULL-terminate them.
> > > Sorry about that, here's the fix:
> > >
> > > * * * * *
> > >
> > > The missing NULL at the end of two sysfs file groups causes a kernel
> > > crash when calling sysfs_create_group().
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > ---
> > >  drivers/hwmon/adm1026.c |    2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > --- linux-2.6.25-rc0.orig/drivers/hwmon/adm1026.c       2008-02-10 11:21:54.000000000 +0100
> > > +++ linux-2.6.25-rc0/drivers/hwmon/adm1026.c    2008-02-10 18:51:00.000000000 +0100
> > > @@ -1624,6 +1624,7 @@ static struct attribute *adm1026_attribu
> > >         &dev_attr_temp3_crit_enable.attr,
> > >         &dev_attr_temp3_auto_point1_pwm.attr,
> > >         &dev_attr_temp3_auto_point2_pwm.attr,
> > > +       NULL
> > >  };
> > >
> > >  static const struct attribute_group adm1026_group_temp3 = {
> > > @@ -1639,6 +1640,7 @@ static struct attribute *adm1026_attribu
> > >         &sensor_dev_attr_in9_max.dev_attr.attr,
> > >         &sensor_dev_attr_in9_min.dev_attr.attr,
> > >         &sensor_dev_attr_in9_alarm.dev_attr.attr,
> > > +       NULL
> > >  };
> > >
> > >  static const struct attribute_group adm1026_group_in8_9 = {
> > >
> > > * * * * *
> > 
> > it works. Thanks
> 
> Great, thanks. Mark, please include this patch in your next patch to
> Linus for 2.6.25.

Can someone send it to stable@kernel.org also when it goes into Linus's
tree, as it looks like a pretty bad thing :)

thanks,

greg k-h

  reply	other threads:[~2008-02-12 15:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10  7:55 panic about sysfs with adm1026 Yinghai Lu
2008-02-10 17:10 ` Greg KH
     [not found]   ` <20080210190115.2ebd4124@hyperion.delvare>
2008-02-10 20:31     ` [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026) Yinghai Lu
2008-02-11 23:39     ` Yinghai Lu
2008-02-12  8:27       ` Jean Delvare
2008-02-12 15:27         ` Greg KH [this message]
2008-02-12 15:37           ` Jean Delvare
2008-02-12 16:02             ` Greg KH
2008-02-12 16:13             ` [lm-sensors] " MillTek
2008-02-13 13:17     ` Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080212152715.GB19441@kroah.com \
    --to=greg@kroah.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    --cc=yhlu.kernel@gmail.com \
    --subject='Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).