LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: petkovbb@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide-scsi: do non-atomic pc->flags testing
Date: Tue, 12 Feb 2008 21:17:14 +0100 [thread overview]
Message-ID: <200802122117.14156.bzolnier@gmail.com> (raw)
In-Reply-To: <20080212152550.GE4530@gollum.tnic>
On Tuesday 12 February 2008, Borislav Petkov wrote:
> commit 272976f0f5754707f9e41da315717a6eb8d9d536
> Author: Borislav Petkov <petkovbb@gmail.com>
> Date: Tue Feb 12 16:22:44 2008 +0100
>
> ide-scsi: do non-atomic pc->flags testing
>
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
>
> diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
> index 5ec421c..eb84cdc 100644
> --- a/drivers/scsi/ide-scsi.c
> +++ b/drivers/scsi/ide-scsi.c
> @@ -319,8 +319,10 @@ static int idescsi_end_request (ide_drive_t *drive, int uptodate, int nrsecs)
> pc = opc;
> rq = pc->rq;
> pc->scsi_cmd->result = (CHECK_CONDITION << 1) |
> - ((test_bit(PC_TIMEDOUT, &pc->flags)?DID_TIME_OUT:DID_OK) << 16);
> - } else if (test_bit(PC_TIMEDOUT, &pc->flags)) {
> + (((pc->flags & PC_TIMEDOUT) ?
> + DID_TIME_OUT :
> + DID_OK) << 16);
> + } else if (pc->flags & PC_TIMEDOUT) {
How's about renaming flag defines to PC_FLAG_* at the same time
(like it was done for other ATAPI drivers)?
Otherwise looks good.
next prev parent reply other threads:[~2008-02-12 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 8:34 [PATCH 0/4] ide: generic packet command representation Borislav Petkov
2008-02-11 8:34 ` [PATCH 1/4] ide: add generic packet command representation ide_atapi_pc Borislav Petkov
2008-02-11 8:34 ` [PATCH 2/4] ide-floppy: convert driver to using generic ide_atapi_pc Borislav Petkov
2008-02-11 8:34 ` [PATCH 3/4] ide-tape: " Borislav Petkov
2008-02-11 8:34 ` [PATCH 4/4] ide-scsi: " Borislav Petkov
2008-02-12 0:09 ` [PATCH 0/4] ide: generic packet command representation Bartlomiej Zolnierkiewicz
2008-02-12 5:59 ` Borislav Petkov
[not found] ` <200802121328.48515.bzolnier@gmail.com>
2008-02-12 15:25 ` [PATCH] ide-scsi: do non-atomic pc->flags testing Borislav Petkov
2008-02-12 20:17 ` Bartlomiej Zolnierkiewicz [this message]
2008-02-15 14:04 ` [PATCH 0/4] ide: generic packet command representation Jan Engelhardt
2008-02-15 14:24 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802122117.14156.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--subject='Re: [PATCH] ide-scsi: do non-atomic pc->flags testing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).