LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: linux-kernel@vger.kernel.org
Cc: hskinnemoen@atmel.com, shannon.nelson@intel.com, olof@lixom.net,
	yur@emcraft.com
Subject: [PATCH 0/4] async_tx: fix dependency handling and related cleanups
Date: Wed, 13 Feb 2008 00:02:52 -0700	[thread overview]
Message-ID: <20080213065944.793.23537.stgit@dwillia2-linux.ch.intel.com> (raw)

Injecting channel-switch-interrupts has been broken for a while now.  It
has not been a problem in practice because the only in-tree driver that
relied on this functionality was the iop3xx version of iop-adma, and it
had a bug-masking local workaround.  Three side benefits arise from this
fix:

1/ dma_async_tx_descriptor sheds two list_heads
2/ Locking is made sane in that dma drivers no longer need to directly
   touch dma_async_tx_descriptor.lock
3/ dma_device.device_dependency_added is no longer needed

Testing shows that iop-adma now gets by without the 'watchdog'
workaround.

---

Dan Williams (4):
      iop-adma: remove the workaround for missed interrupts on iop3xx
      async_tx: kill ->device_dependency_added
      async_tx: fix multiple dependency submission
      async_tx: checkpatch says s/__FUNCTION__/__func__/g


 crypto/async_tx/async_memcpy.c         |    6 -
 crypto/async_tx/async_memset.c         |    6 -
 crypto/async_tx/async_tx.c             |  203 ++++++++++++++++++++++++++------
 crypto/async_tx/async_xor.c            |   12 +-
 drivers/dma/dmaengine.c                |    3 
 drivers/dma/ioat_dma.c                 |   12 --
 drivers/dma/iop-adma.c                 |   21 +--
 include/asm-arm/arch-iop13xx/adma.h    |    5 -
 include/asm-arm/hardware/iop3xx-adma.h |    8 -
 include/asm-arm/hardware/iop_adma.h    |    2 
 include/linux/dmaengine.h              |   11 --
 11 files changed, 185 insertions(+), 104 deletions(-)

-- 
Dan

             reply	other threads:[~2008-02-13  7:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  7:02 Dan Williams [this message]
2008-02-13  7:02 ` [PATCH 1/4] async_tx: checkpatch says s/__FUNCTION__/__func__/g Dan Williams
2008-02-13  7:03 ` [PATCH 2/4] async_tx: fix multiple dependency submission Dan Williams
2008-02-13 16:10   ` Nelson, Shannon
2008-02-13  7:03 ` [PATCH 3/4] async_tx: kill ->device_dependency_added Dan Williams
2008-02-13 16:05   ` Nelson, Shannon
2008-02-13  7:03 ` [PATCH 4/4] iop-adma: remove the workaround for missed interrupts on iop3xx Dan Williams
2008-02-15  8:38 ` [PATCH 0/4] async_tx: fix dependency handling and related cleanups Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213065944.793.23537.stgit@dwillia2-linux.ch.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=shannon.nelson@intel.com \
    --cc=yur@emcraft.com \
    --subject='Re: [PATCH 0/4] async_tx: fix dependency handling and related cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).