LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: "Robert Richter" <robert.richter@amd.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"LKML" <linux-kernel@vger.kernel.org>,
	"Robert Richter" <robert.richter@amd.com>
Subject: Re: [patch 1/2] x86: apic: Export symbols for extended interrupt LVT functions
Date: Wed, 13 Feb 2008 14:32:56 -0800	[thread overview]
Message-ID: <20080213143256.54e9a3c7@laptopd505.fenrus.org> (raw)
In-Reply-To: <20080213151841.520543000@amd.com>

On Wed, 13 Feb 2008 16:19:36 +0100 (CET)
"Robert Richter" <robert.richter@amd.com> wrote:

> Signed-off-by: Robert Richter <robert.richter@amd.com>
> ---
>  arch/x86/kernel/apic_64.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
> index d8d03e0..2a9f4bc 100644
> --- a/arch/x86/kernel/apic_64.c
> +++ b/arch/x86/kernel/apic_64.c
> @@ -215,12 +215,14 @@ u8 setup_APIC_eilvt_mce(u8 vector, u8 msg_type,
> u8 mask) setup_APIC_eilvt(APIC_EILVT_LVTOFF_MCE, vector, msg_type,
> mask); return APIC_EILVT_LVTOFF_MCE;
>  }
> +EXPORT_SYMBOL(setup_APIC_eilvt_mce);
>  
>  u8 setup_APIC_eilvt_ibs(u8 vector, u8 msg_type, u8 mask)
>  {
>  	setup_APIC_eilvt(APIC_EILVT_LVTOFF_IBS, vector, msg_type,
> mask); return APIC_EILVT_LVTOFF_IBS;
>  }
> +EXPORT_SYMBOL(setup_APIC_eilvt_ibs);

which modules would even consider using any of these?
Doesn't sound like something we should export..


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  reply	other threads:[~2008-02-13 22:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 15:19 [patch 0/2] x86: Add AMD Barcelona extended interrupt support for 32bit Robert Richter
2008-02-13 15:19 ` [patch 2/2] x86: apic: Extended interrupt LVT support for AMD Barcelona (32bit) Robert Richter
2008-02-17 17:07   ` Ingo Molnar
2008-02-13 15:19 ` [patch 1/2] x86: apic: Export symbols for extended interrupt LVT functions Robert Richter
2008-02-13 22:32   ` Arjan van de Ven [this message]
2008-02-14  9:40     ` Robert Richter
2008-02-14 16:47       ` Arjan van de Ven
2008-06-19 17:00         ` Robert Richter
2008-06-20  2:36           ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213143256.54e9a3c7@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [patch 1/2] x86: apic: Export symbols for extended interrupt LVT functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).