LKML Archive on
help / color / mirror / Atom feed
From: KOSAKI Motohiro <>
To: Andrew Morton <>
Subject: Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller
Date: Wed, 13 Feb 2008 15:37:13 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Andrew

> > and, It is judged out of trouble at the fllowing situations.
> >  o memory pressure decrease and stop moves an anonymous page to the
> > inactive list.
> >  o free pages increase than (pages_high+lowmem_reserve)*2.
> This seems rather arbitrary.  Why choose this stage in the page
> reclaimation process rather than some other stage?
> If this feature is useful then I'd expect that some applications would want
> notification at different times, or at different levels of VM distress.  So
> this semi-randomly-chosen notification point just won't be strong enough in
> real-world use.

actually, This portion become code broat through some bug reports.

Yes, I think it again and implement it more simplefy.

> Does this change work correctly and appropriately for processes which are
> running in a cgroup memory controller?

nice point out.

to be honest, I don't think at mem-cgroup until now.
I will implement it at next post.

> Given the amount of code which these patches add, and the subsequent
> maintenance burden, and the unlikelihood of getting many applications to
> actually _use_ the interface, it is not obvious to me that inclusion in the
> kernel is justifiable, sorry.

I'll implement it again more simplefy.

> memory_pressure_notify() is far too large to be inlined.

I will fix it.

> Some of the patches were wordwrapped.

I will don't use gmail at next post.

I hope merge only poll_wait_exclusive() and wake_up_locked_nr()
if you don't mind.

this 2 portion anybody noclaim about 2 month.
and I think it is useful function by many people.

  reply	other threads:[~2008-02-13  6:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 15:24 KOSAKI Motohiro
2008-02-12 22:56 ` Andrew Morton
2008-02-13  6:37   ` KOSAKI Motohiro [this message]
2008-02-13 15:03     ` Andi Kleen
2008-02-14  0:25       ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).