LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	muli@il.ibm.com, jdmason@kudzu.us, linux-ide@vger.kernel.org,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
	discuss@x86-64.org
Subject: Re: pci_get_device_reverse(), why does Calgary need this?
Date: Wed, 13 Feb 2008 09:28:24 -0800	[thread overview]
Message-ID: <20080213172824.GB10733@kroah.com> (raw)
In-Reply-To: <200802131334.12351.bzolnier@gmail.com>

On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday 13 February 2008, Greg KH wrote:
> > On Wed, Feb 13, 2008 at 02:17:37AM +0000, Alan Cox wrote:
> > > > Why does the calgary driver need this?  Can we just use pci_get_device()
> > > > instead?  Why do you need to walk the device list backwards?  Do you get
> > > > false positives going forward?
> > > 
> > > It doesn't look to be performance critical so the driver can
> > > pci_get_device until the end and use the final hit anyway.
> > 
> > That would make more sense.
> > 
> > > IDE reverse is more problematic but nobody seems to use it.
> > 
> > I've seen two posters say they use it.  I'm wondering what it is really
> > solving if they use it, and why if it's really needed, scsi never had to
> > implement such a hack...
> 
> It is no longer solving anything, just adds more pain. ;)
> 
> [ The option comes from 2.2.x (so long before LABEL=/ and /dev/disk/by-id/
>   became popular).  Some "off-board" controllers integrated on motherboards
>   used to appear before "on-board" IDE on PCI bus so this option was meant
>   to preserve the legacy ordering. ]
> 
> Since it is valid only when "Probe IDE PCI devices in the PCI bus order
> (DEPRECATED)" config option is used it is already on its way out (though
> marking it as obsoleted would make it more explicit).
> 
> I think that removing "ide=reverse" in 2.6.26 would be OK...

Great, thanks for your blessing.  I'll make up a patch and send it to
you for approval.

thanks,

greg k-h

  reply	other threads:[~2008-02-13 17:35 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13  0:15 "ide=reverse" do we still " Greg KH
2008-02-13  0:16 ` pci_get_device_reverse(), why does Calgary " Greg KH
2008-02-13  2:17   ` Alan Cox
2008-02-13  4:45     ` Greg KH
2008-02-13 12:34       ` Bartlomiej Zolnierkiewicz
2008-02-13 17:28         ` Greg KH [this message]
2008-02-13 18:16           ` Greg KH
2008-02-13 22:20             ` Bartlomiej Zolnierkiewicz
2008-02-13 23:41               ` Greg KH
2008-02-14  0:02                 ` Bartlomiej Zolnierkiewicz
2008-02-14  4:58                   ` Greg KH
2008-02-14 13:09               ` Sergei Shtylyov
2008-02-14  7:44             ` [discuss] " Andreas Jaeger
2008-02-14 12:11               ` Bartlomiej Zolnierkiewicz
2008-02-15  7:17                 ` Greg KH
2008-02-20  0:39                 ` Greg KH
2008-02-13  9:32   ` Muli Ben-Yehuda
2008-02-13 17:32     ` Greg KH
2008-02-13 17:47       ` Muli Ben-Yehuda
2008-02-13 18:14         ` Greg KH
2008-02-15  7:17           ` Greg KH
2008-02-15  7:48             ` Muli Ben-Yehuda
2008-02-15 15:20               ` Greg KH
2008-02-15 15:31                 ` Sam Ravnborg
2008-02-15 15:46                   ` yong xue
2008-02-15 18:28                   ` Greg KH
2008-02-17  7:53                     ` Muli Ben-Yehuda
2008-02-13  1:41 ` "ide=reverse" do we still " Rene Herman
2008-02-13  4:44   ` Greg KH
2008-02-13 12:06     ` Rene Herman
2008-02-13 12:16       ` Michael Ellerman
2008-02-13 12:46         ` Rene Herman
2008-02-13 22:39           ` Michael Ellerman
2008-02-13 12:57       ` Rene Herman
2008-02-14 17:16     ` Bill Davidsen
2008-02-15 13:58       ` Matthew Wilcox
2008-02-13  2:43 ` Ken Moffat
2008-02-13  4:43   ` Greg KH
2008-02-13 15:32     ` Ken Moffat
2008-02-19 15:08       ` Ken Moffat
2008-02-13  7:54 ` [discuss] " Dirk GOUDERS
2008-02-13  8:26   ` Greg KH
2008-02-13  8:54     ` Dirk GOUDERS
2008-02-13 20:00     ` Dirk GOUDERS
2008-02-13 20:48       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213172824.GB10733@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=discuss@x86-64.org \
    --cc=jdmason@kudzu.us \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=muli@il.ibm.com \
    --subject='Re: pci_get_device_reverse(), why does Calgary need this?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).