Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

[Pierre Ossman <drzeus-list@drzeus.cx>]

On Tue, 29 Jan 2008 19:10:13 +0100
Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:

> +
> +/* Those printks take an awful lot of time... */
> +#ifndef DEBUG
> +static unsigned int fmax = 15000000U;
> +#else
> +static unsigned int fmax = 1000000U;
> +#endif
> +module_param(fmax, uint, 0444);
> +MODULE_PARM_DESC(fmax, "Max frequency in Hz of the MMC bus clock");
> +

I think this was meant to go away.

> +
> +static int req_dbg_open(struct inode *inode, struct file *file)
> +{

And this should go into the core.

> +
> +static int __exit atmci_remove(struct platform_device *pdev)
> +{
> +	struct atmel_mci *host = platform_get_drvdata(pdev);
> +
> +	platform_set_drvdata(pdev, NULL);
> +
> +	if (host) {
> +		atmci_cleanup_debugfs(host);
> +
> +		if (host->detect_pin >= 0) {
> +			free_irq(gpio_to_irq(host->detect_pin),host->mmc);
> +			cancel_delayed_work(&host->mmc->detect);

I also pointed this out. mmc_remove_host() will synchronize this for
you.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org