LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] kernel/cpuset.c: make 3 functions static
@ 2008-02-13 21:30 Adrian Bunk
2008-02-14 12:51 ` Paul Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-02-13 21:30 UTC (permalink / raw)
To: Cliff Wickman, pj, simon.derr; +Cc: linux-kernel
This patch makes the following needlessly global functions static:
- cpuset_test_cpumask()
- cpuset_change_cpumask()
- cpuset_do_move_task()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
kernel/cpuset.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
581c9289db3ce36232a9102505f476681c7ecf4c diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 3e296ed..5c21ae9 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -710,7 +710,8 @@ static inline int started_after(void *p1, void *p2)
* Return nonzero if this tasks's cpus_allowed mask should be changed (in other
* words, if its mask is not equal to its cpuset's mask).
*/
-int cpuset_test_cpumask(struct task_struct *tsk, struct cgroup_scanner *scan)
+static int cpuset_test_cpumask(struct task_struct *tsk,
+ struct cgroup_scanner *scan)
{
return !cpus_equal(tsk->cpus_allowed,
(cgroup_cs(scan->cg))->cpus_allowed);
@@ -727,7 +728,8 @@ int cpuset_test_cpumask(struct task_struct *tsk, struct cgroup_scanner *scan)
* We don't need to re-check for the cgroup/cpuset membership, since we're
* holding cgroup_lock() at this point.
*/
-void cpuset_change_cpumask(struct task_struct *tsk, struct cgroup_scanner *scan)
+static void cpuset_change_cpumask(struct task_struct *tsk,
+ struct cgroup_scanner *scan)
{
set_cpus_allowed(tsk, (cgroup_cs(scan->cg))->cpus_allowed);
}
@@ -1648,7 +1650,8 @@ int __init cpuset_init(void)
* Called by cgroup_scan_tasks() for each task in a cgroup.
* Return nonzero to stop the walk through the tasks.
*/
-void cpuset_do_move_task(struct task_struct *tsk, struct cgroup_scanner *scan)
+static void cpuset_do_move_task(struct task_struct *tsk,
+ struct cgroup_scanner *scan)
{
struct cpuset_hotplug_scanner *chsp;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] kernel/cpuset.c: make 3 functions static
2008-02-13 21:30 [2.6 patch] kernel/cpuset.c: make 3 functions static Adrian Bunk
@ 2008-02-14 12:51 ` Paul Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Paul Jackson @ 2008-02-14 12:51 UTC (permalink / raw)
To: Adrian Bunk; +Cc: cpw, simon.derr, linux-kernel
Adrian wrote:
> This patch makes the following needlessly global functions static:
> - cpuset_test_cpumask()
> - cpuset_change_cpumask()
> - cpuset_do_move_task()
Thanks.
Signed-off-by: Paul Jackson <pj@sgi.com>
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-14 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-13 21:30 [2.6 patch] kernel/cpuset.c: make 3 functions static Adrian Bunk
2008-02-14 12:51 ` Paul Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).