LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 2/2]  tc1100-wmi - Fail gracefully if ACPI is disabled
Date: Thu, 14 Feb 2008 01:11:41 -0500	[thread overview]
Message-ID: <200802140111.41883.lenb@kernel.org> (raw)
In-Reply-To: <200802111955.46199.carlos@strangeworlds.co.uk>

applied.

thanks,
-len

On Monday 11 February 2008 14:55, Carlos Corbacho wrote:
> tc1100-wmi - Fail gracefully if ACPI is disabled
> 
> From: Carlos Corbacho <carlos@strangeworlds.co.uk>
> 
> WMI drivers, like their ACPI counterparts, should also check if ACPI is
> disabled or not, and bail out if so, otherwise we cause a crash.
> 
> Spotted by Ingo Molnar.
> 
> Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Linus Torvalds <torvalds@linux-foundation.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Len Brown <lenb@kernel.org>
> ---
> 
>  drivers/misc/tc1100-wmi.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/misc/tc1100-wmi.c b/drivers/misc/tc1100-wmi.c
> index f25e4c9..cb8f79f 100644
> --- a/drivers/misc/tc1100-wmi.c
> +++ b/drivers/misc/tc1100-wmi.c
> @@ -263,6 +263,9 @@ static int __init tc1100_init(void)
>  {
>  	int result = 0;
>  
> +	if (acpi_disabled)
> +		return -ENODEV;
> +
>  	if (!wmi_has_guid(GUID))
>  		return -ENODEV;
>  
> 

  reply	other threads:[~2008-02-14  6:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08  6:45 [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2) Len Brown
2008-02-09  6:17 ` Ingo Molnar
2008-02-09  6:19   ` Ingo Molnar
2008-02-09 11:42     ` Carlos Corbacho
2008-02-11  9:17       ` Ingo Molnar
2008-02-11 19:23         ` Carlos Corbacho
2008-02-11 19:55           ` [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled Carlos Corbacho
2008-02-12  4:41             ` Linus Torvalds
2008-02-12 15:12               ` Ingo Molnar
2008-02-12 19:28               ` Carlos Corbacho
2008-02-11 19:55           ` [PATCH 2/2] tc1100-wmi " Carlos Corbacho
2008-02-14  6:11             ` Len Brown [this message]
2008-02-14  6:15               ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802140111.41883.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=carlos@strangeworlds.co.uk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH 2/2]  tc1100-wmi - Fail gracefully if ACPI is disabled' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).