LKML Archive on
help / color / mirror / Atom feed
From: Roland McGrath <>
To: Linus Torvalds <>,
	Andrew Morton <>
Cc: Mathieu Desnoyers <>
Subject: [PATCH] samples: build fix
Date: Wed, 13 Feb 2008 19:45:41 -0800 (PST)	[thread overview]
Message-ID: <20080214034541.EF1BD270192@magilla.localdomain> (raw)

The samples/ subdirectory contains only modules.
But the only make run done there is in commands for vmlinux.
I can't see why this was ever done in this nonstandard fashion.
As things stand, the modules don't get built by 'make modules'.

I didn't make the addition of the directory use core-$(CONFIG_SAMPLES)
because there is no other conditional like that in the top-level Makefile
and samples/Makefile already uses obj-$(CONFIG_SAMPLES) as if it expects
always to be included.

Signed-off-by: Roland McGrath <>
 Makefile |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index c162370..9e9ce33 100644
--- a/Makefile
+++ b/Makefile
@@ -602,7 +602,7 @@ export mod_strip_cmd
 ifeq ($(KBUILD_EXTMOD),)
-core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/
+core-y		+= kernel/ mm/ fs/ ipc/ security/ crypto/ block/ samples/
 vmlinux-dirs	:= $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
 		     $(core-y) $(core-m) $(drivers-y) $(drivers-m) \
@@ -802,9 +802,6 @@ vmlinux: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) vmlinux.o $(kallsyms.o)
 	$(Q)$(MAKE) -f $(srctree)/Makefile headers_check
-	$(Q)$(MAKE) $(build)=samples
 	$(call vmlinux-modpost)
 	$(call if_changed_rule,vmlinux__)
 	$(Q)rm -f .old_version

             reply	other threads:[~2008-02-14  3:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14  3:45 Roland McGrath [this message]
2008-02-14 13:27 ` Mathieu Desnoyers
2008-02-14 19:26   ` Roland McGrath
2008-02-14 19:46   ` Sam Ravnborg
2008-02-14 20:02     ` Roland McGrath
2008-02-14 20:09       ` Randy Dunlap
2008-02-14 20:42       ` Sam Ravnborg
2008-02-14 20:04     ` Mathieu Desnoyers
2008-02-14 21:06       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080214034541.EF1BD270192@magilla.localdomain \ \ \ \ \
    --subject='Re: [PATCH] samples: build fix' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).