LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: pageexec@freemail.hu
Cc: Arjan van de Ven <arjan@infradead.org>,
	linux-kernel@vger.kernel.org, mingo@elte.hu,
	torvalds@linux-foundation.org
Subject: Re: vmsplice exploits, stack protector and Makefiles
Date: Thu, 14 Feb 2008 08:43:27 +0100	[thread overview]
Message-ID: <20080214074327.GD17552@uranus.ravnborg.org> (raw)
In-Reply-To: <47B30F05.29637.9A21F9B@pageexec.freemail.hu>

> --- linux-2.6.24.2/arch/x86/kernel/Makefile_64	2008-01-24 23:58:37.000000000 
> +0100
> +++ linux-2.6.24.2-pax/arch/x86/kernel/Makefile_64	2008-02-13 
> 11:36:14.000000000 +0100
> @@ -42,4 +42,6 @@ obj-$(CONFIG_PCI)		+= early-quirks.o
>  obj-y				+= topology.o
>  obj-y				+= pcspeaker.o
>  
> -CFLAGS_vsyscall_64.o		:= $(PROFILING) -g0
> +CFLAGS_vsyscall_64.o		:= $(PROFILING) -g0 -fno-stack-protector
> +CFLAGS_hpet.o			:= -fno-stack-protector
> +CFLAGS_tsc_64.o			:= -fno-stack-protector

We should use:
nostackp := $(call cc-option, -fno-stack-protector)
+CFLAGS_vsyscall_64.o		:= $(PROFILING) -g0 $(nostackp)
+CFLAGS_hpet.o			:= $(nostackp)
+CFLAGS_tsc_64.o		:= $(nostackp)

(or somthing similar)

because we cannot rely on that all gcc versions has support
for -fno-stack-protector

	Sam

      parent reply	other threads:[~2008-02-14  7:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 17:00 Arjan van de Ven
2008-02-12 18:50 ` Sam Ravnborg
2008-02-12 19:08   ` Arjan van de Ven
2008-02-12 19:36     ` Sam Ravnborg
2008-02-13 13:38 ` pageexec
2008-02-13 15:29   ` Ingo Molnar
2008-02-13 16:29     ` Randy Dunlap
2008-02-13 15:48       ` pageexec
2008-02-14 12:20         ` Jan Engelhardt
2008-02-13 16:48     ` Ingo Molnar
2008-02-13 16:15       ` pageexec
2008-02-14  6:16         ` Ingo Molnar
2008-02-14  7:30           ` Ingo Molnar
2008-02-14 10:23             ` pageexec
2008-02-13 15:53   ` Linus Torvalds
2008-02-13 16:01     ` Ingo Molnar
2008-02-13 17:16       ` Sam Ravnborg
2008-02-14  6:12         ` Ingo Molnar
2008-02-14  7:43   ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080214074327.GD17552@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pageexec@freemail.hu \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: vmsplice exploits, stack protector and Makefiles' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).