LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: adrian.bunk@movial.fi, mingo@elte.hu,
	linux-kernel@vger.kernel.org, riku.voipio@movial.fi,
	mikpe@it.uu.se, buytenh@wantstofly.org, rusty@rustcorp.com.au,
	stable@kernel.org
Subject: Re: futex local DoS on most architectures
Date: Thu, 14 Feb 2008 13:46:42 -0800	[thread overview]
Message-ID: <20080214134642.600282f1.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0802111442130.12988@apollo.tec.linutronix.de>

On Mon, 11 Feb 2008 14:59:34 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 11 Feb 2008, Adrian Bunk wrote:
> 
> > The issue described in [1] is still present and unfixed (and even the 
> > fix there wasn't complete since it didn't cover SMP).
> 
> Damn, this slipped through my attention completely. Hotfix (which can
> be easily backported) below.
>  
> > Thanks to Riku Voipio for noting that it is still unfixed.
> > 
> > cu
> > Adrian
> > 
> > [1] http://lkml.org/lkml/2007/8/1/474
> 
> -------->
> 
> Subject: futex: disable PI/robust on archs w/o valid implementation
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> We have to disable the complete PI/robust functionality for those
> archs, which do not implement futex_atomic_cmpxchg_inatomic(). The
> code in question relies on a valid implementation and does not expect
> -ENOSYS, which is returned by the stub implementation in
> asm-generic/futex.h
> 
> Pointed out by: Mikael Pettersson, Riku Voipio and Adrian Bunk
> 
> This patch is intended for easy backporting and needs to be cleaned up
> further for current mainline.

So...

I queued up this version with a cc to stable under the assumption that this
is the patch which should be applied to 2.6.x.y, but this version is not
the one which will go into 2.6.25.

Correct?

If so: messy.  The stable guys might want to wait until they see the real
2.6.25 patch and perhaps prefer to backport that version.



  parent reply	other threads:[~2008-02-14 21:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 13:07 Adrian Bunk
2008-02-11 13:56 ` Mikael Pettersson
2008-02-11 13:59 ` Thomas Gleixner
2008-02-11 14:16   ` Lennert Buytenhek
2008-02-12 12:50   ` Riku Voipio
2008-02-14 21:46   ` Andrew Morton [this message]
2008-02-15  1:19     ` Thomas Gleixner
2008-02-15  1:23       ` [PATCH 1/2] futex: fix init order Thomas Gleixner
2008-02-15  1:36       ` [PATCH 2/2] futex: runtime enable pi and robust functionality Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080214134642.600282f1.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adrian.bunk@movial.fi \
    --cc=buytenh@wantstofly.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=mingo@elte.hu \
    --cc=riku.voipio@movial.fi \
    --cc=rusty@rustcorp.com.au \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: futex local DoS on most architectures' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).