LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] markers: Fix build for MODULES=n.
@ 2008-02-14  7:25 Paul Mundt
  2008-02-14 13:32 ` Mathieu Desnoyers
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Mundt @ 2008-02-14  7:25 UTC (permalink / raw)
  To: Mathieu Desnoyers; +Cc: Andrew Morton, linux-kernel

  CC      kernel/marker.o
kernel/marker.c: In function 'marker_update_probes':
kernel/marker.c:627: error: too few arguments to function 'module_update_markers'
make[1]: *** [kernel/marker.o] Error 1
make: *** [kernel] Error 2

module_update_markers() doesn't take any arguments, update the MODULES=n
version of it to reflect that.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

---

 include/linux/module.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/module.h b/include/linux/module.h
index 330bec0..819c4e8 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -567,8 +567,7 @@ static inline void print_modules(void)
 {
 }
 
-static inline void module_update_markers(struct module *probe_module,
-		int *refcount)
+static inline void module_update_markers(void)
 {
 }
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] markers: Fix build for MODULES=n.
  2008-02-14  7:25 [PATCH] markers: Fix build for MODULES=n Paul Mundt
@ 2008-02-14 13:32 ` Mathieu Desnoyers
  2008-02-14 14:31   ` Paul Mundt
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Desnoyers @ 2008-02-14 13:32 UTC (permalink / raw)
  To: Paul Mundt, Andrew Morton, linux-kernel, Adrian Bunk

* Paul Mundt (lethal@linux-sh.org) wrote:
>   CC      kernel/marker.o
> kernel/marker.c: In function 'marker_update_probes':
> kernel/marker.c:627: error: too few arguments to function 'module_update_markers'
> make[1]: *** [kernel/marker.o] Error 1
> make: *** [kernel] Error 2
> 
> module_update_markers() doesn't take any arguments, update the MODULES=n
> version of it to reflect that.
> 

Hi Paul, thanks for submitting this. Adrian-the-roadrunner has been
faster than you though. :) He already submitted this fix here :

http://lkml.org/lkml/2008/2/13/714

Mathieu


> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> 
> ---
> 
>  include/linux/module.h |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/module.h b/include/linux/module.h
> index 330bec0..819c4e8 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -567,8 +567,7 @@ static inline void print_modules(void)
>  {
>  }
>  
> -static inline void module_update_markers(struct module *probe_module,
> -		int *refcount)
> +static inline void module_update_markers(void)
>  {
>  }
>  

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] markers: Fix build for MODULES=n.
  2008-02-14 13:32 ` Mathieu Desnoyers
@ 2008-02-14 14:31   ` Paul Mundt
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2008-02-14 14:31 UTC (permalink / raw)
  To: Mathieu Desnoyers; +Cc: Andrew Morton, linux-kernel, Adrian Bunk

On Thu, Feb 14, 2008 at 08:32:44AM -0500, Mathieu Desnoyers wrote:
> * Paul Mundt (lethal@linux-sh.org) wrote:
> >   CC      kernel/marker.o
> > kernel/marker.c: In function 'marker_update_probes':
> > kernel/marker.c:627: error: too few arguments to function 'module_update_markers'
> > make[1]: *** [kernel/marker.o] Error 1
> > make: *** [kernel] Error 2
> > 
> > module_update_markers() doesn't take any arguments, update the MODULES=n
> > version of it to reflect that.
> > 
> 
> Hi Paul, thanks for submitting this. Adrian-the-roadrunner has been
> faster than you though. :) He already submitted this fix here :
> 
> http://lkml.org/lkml/2008/2/13/714
> 
No worries, I was just tossing out stuff I hit with my randconfigs now
that things are slowing down. It's difficult to verify your own stuff
when the rest of the tree keeps breaking. It's good to know there are
other people doing similar tests ;-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-14 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-14  7:25 [PATCH] markers: Fix build for MODULES=n Paul Mundt
2008-02-14 13:32 ` Mathieu Desnoyers
2008-02-14 14:31   ` Paul Mundt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).