LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH
@ 2008-02-14 20:54 Erez Zadok
  2008-02-14 20:57 ` Roland Dreier
  2008-02-14 21:00 ` Sam Ravnborg
  0 siblings, 2 replies; 5+ messages in thread
From: Erez Zadok @ 2008-02-14 20:54 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Using: v2.6.25-rc1-120-ge760e71

In a normal compilation, I might this message:

...
  MODPOST vmlinux.o
WARNING: modpost: Found 4 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
...

I can indeed try to re-make, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
command line, but I can't turn on the option in my .config.  That's because
the option depends on "UNDEFINED".  (Was that an attempt to "hide" the
option?  Why?)  The following small patch allows me to set the option in my
.config.

Cheers,
Erez.



Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a370fe8..3399d9d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -81,7 +81,6 @@ config HEADERS_CHECK
 
 config DEBUG_SECTION_MISMATCH
 	bool "Enable full Section mismatch analysis"
-	depends on UNDEFINED
 	help
 	  The section mismatch analysis checks if there are illegal
 	  references from one section to another section.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH
  2008-02-14 20:54 [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH Erez Zadok
@ 2008-02-14 20:57 ` Roland Dreier
  2008-02-14 21:00 ` Sam Ravnborg
  1 sibling, 0 replies; 5+ messages in thread
From: Roland Dreier @ 2008-02-14 20:57 UTC (permalink / raw)
  To: Erez Zadok; +Cc: Andrew Morton, linux-kernel

 > I can indeed try to re-make, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
 > command line, but I can't turn on the option in my .config.  That's because
 > the option depends on "UNDEFINED".  (Was that an attempt to "hide" the
 > option?  Why?)  The following small patch allows me to set the option in my
 > .config.

It seems this was intentional, see the log for e5f95c8b:

    kbuild: print only total number of section mismatces found
    
    We have too many section mismatches detected at the moment.
    So silence modpost and prevent the option from being
    set in a typical allyesconfig build.
    
    Tell the user how to see all the deteils in the summary
    message from modpost.
    
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH
  2008-02-14 20:54 [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH Erez Zadok
  2008-02-14 20:57 ` Roland Dreier
@ 2008-02-14 21:00 ` Sam Ravnborg
  2008-02-14 21:05   ` Erez Zadok
  1 sibling, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2008-02-14 21:00 UTC (permalink / raw)
  To: Erez Zadok; +Cc: Andrew Morton, linux-kernel

On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote:
> Using: v2.6.25-rc1-120-ge760e71
> 
> In a normal compilation, I might this message:
> 
> ...
>   MODPOST vmlinux.o
> WARNING: modpost: Found 4 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> ...
> 
> I can indeed try to re-make, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
> command line, but I can't turn on the option in my .config.  That's because
> the option depends on "UNDEFINED".  (Was that an attempt to "hide" the
> option?  Why?)  The following small patch allows me to set the option in my
> .config.

It was done so on purpose.
The rationale here is that we yet have too many section mismatch for
a typical build to pass my "good stomach" test.
So until we get down on an acceptable level we should not be
too noisy.
And I wanted it to be turned off also for allyesconfig builds.

I hope to spend time on the reaming warnings soon but the
option will not be enabled until latest next mergewindow.

You could argue that I could have doen this in better ways
The present version was just simple.

	Sam

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH 
  2008-02-14 21:00 ` Sam Ravnborg
@ 2008-02-14 21:05   ` Erez Zadok
  2008-02-14 21:11     ` Sam Ravnborg
  0 siblings, 1 reply; 5+ messages in thread
From: Erez Zadok @ 2008-02-14 21:05 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: Erez Zadok, Andrew Morton, linux-kernel

In message <20080214210003.GF21894@uranus.ravnborg.org>, Sam Ravnborg writes:
> On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote:
> > Using: v2.6.25-rc1-120-ge760e71
> > 
> > In a normal compilation, I might this message:
> > 
> > ...
> >   MODPOST vmlinux.o
> > WARNING: modpost: Found 4 section mismatch(es).
> > To see full details build your kernel with:
> > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > ...
> > 
> > I can indeed try to re-make, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
> > command line, but I can't turn on the option in my .config.  That's because
> > the option depends on "UNDEFINED".  (Was that an attempt to "hide" the
> > option?  Why?)  The following small patch allows me to set the option in my
> > .config.
> 
> It was done so on purpose.
> The rationale here is that we yet have too many section mismatch for
> a typical build to pass my "good stomach" test.
> So until we get down on an acceptable level we should not be
> too noisy.
> And I wanted it to be turned off also for allyesconfig builds.
> 
> I hope to spend time on the reaming warnings soon but the
> option will not be enabled until latest next mergewindow.
> 
> You could argue that I could have doen this in better ways
> The present version was just simple.
> 
> 	Sam

Thanks, Sam.  That explains it.  Perhaps a small comment next to the Kconfig
entry might help explain why the option is "hidden" for now, so others won't
bother unhiding it again.

Of course, forcing it on might help people to fix those warnings sooner. :-)

Erez.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH
  2008-02-14 21:05   ` Erez Zadok
@ 2008-02-14 21:11     ` Sam Ravnborg
  0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2008-02-14 21:11 UTC (permalink / raw)
  To: Erez Zadok; +Cc: Andrew Morton, linux-kernel

On Thu, Feb 14, 2008 at 04:05:14PM -0500, Erez Zadok wrote:
> In message <20080214210003.GF21894@uranus.ravnborg.org>, Sam Ravnborg writes:
> > On Thu, Feb 14, 2008 at 03:54:04PM -0500, Erez Zadok wrote:
> > > Using: v2.6.25-rc1-120-ge760e71
> > > 
> > > In a normal compilation, I might this message:
> > > 
> > > ...
> > >   MODPOST vmlinux.o
> > > WARNING: modpost: Found 4 section mismatch(es).
> > > To see full details build your kernel with:
> > > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > > ...
> > > 
> > > I can indeed try to re-make, passing CONFIG_DEBUG_SECTION_MISMATCH=y on the
> > > command line, but I can't turn on the option in my .config.  That's because
> > > the option depends on "UNDEFINED".  (Was that an attempt to "hide" the
> > > option?  Why?)  The following small patch allows me to set the option in my
> > > .config.
> > 
> > It was done so on purpose.
> > The rationale here is that we yet have too many section mismatch for
> > a typical build to pass my "good stomach" test.
> > So until we get down on an acceptable level we should not be
> > too noisy.
> > And I wanted it to be turned off also for allyesconfig builds.
> > 
> > I hope to spend time on the reaming warnings soon but the
> > option will not be enabled until latest next mergewindow.
> > 
> > You could argue that I could have doen this in better ways
> > The present version was just simple.
> > 
> > 	Sam
> 
> Thanks, Sam.  That explains it.  Perhaps a small comment next to the Kconfig
> entry might help explain why the option is "hidden" for now, so others won't
> bother unhiding it again.

Something like this?
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a370fe8..8a6b514 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -81,6 +81,8 @@ config HEADERS_CHECK

 config DEBUG_SECTION_MISMATCH
        bool "Enable full Section mismatch analysis"
+# Hide this option until we are down to a reasonable amount of warnings
+# for a typical kernel configuration
        depends on UNDEFINED
        help


	Sam

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-14 21:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-14 20:54 [PATCH] unhide CONFIG_DEBUG_SECTION_MISMATCH Erez Zadok
2008-02-14 20:57 ` Roland Dreier
2008-02-14 21:00 ` Sam Ravnborg
2008-02-14 21:05   ` Erez Zadok
2008-02-14 21:11     ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).