LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>,
	hpa@zytor.com, rjw@sisk.pl, sam@ravnborg.org
Subject: Re: [patch] move wakeup code to .c
Date: Fri, 15 Feb 2008 01:35:06 -0500	[thread overview]
Message-ID: <200802150135.07127.lenb@kernel.org> (raw)
In-Reply-To: <20080210222723.GA1865@elf.ucw.cz>

scripts/checkpatch.pl
ERROR: do not initialise externals to 0 or NULL
#113: FILE: arch/x86/boot/video-mode.c:29:
+int do_restore = 0;    /* Screen contents changed during mode flip */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#644: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:4:
+extern volatile struct wakeup_header wakeup_header;

WARNING: externs should be avoided in .c files
#644: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:4:
+extern volatile struct wakeup_header wakeup_header;

ERROR: need a space before the open parenthesis '('
#710: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:70:
+               while(1);

WARNING: externs should be avoided in .c files
#968: FILE: arch/x86/kernel/acpi/sleep.c:21:
+extern char wakeup_code_start, wakeup_code_end;

WARNING: externs should be avoided in .c files
#970: FILE: arch/x86/kernel/acpi/sleep.c:23:
+extern unsigned long setup_trampoline(void);

WARNING: externs should be avoided in .c files
#971: FILE: arch/x86/kernel/acpi/sleep.c:24:
+extern void wakeup_long64(void);

WARNING: externs should be avoided in .c files
#973: FILE: arch/x86/kernel/acpi/sleep.c:26:
+extern unsigned long saved_video_mode;

WARNING: externs should be avoided in .c files
#974: FILE: arch/x86/kernel/acpi/sleep.c:27:
+extern long saved_magic;

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#975: FILE: arch/x86/kernel/acpi/sleep.c:28:
+extern volatile unsigned long init_rsp;

WARNING: externs should be avoided in .c files
#975: FILE: arch/x86/kernel/acpi/sleep.c:28:
+extern volatile unsigned long init_rsp;

WARNING: externs should be avoided in .c files
#976: FILE: arch/x86/kernel/acpi/sleep.c:29:
+extern void (*initial_code)(void);

WARNING: externs should be avoided in .c files
#978: FILE: arch/x86/kernel/acpi/sleep.c:31:
+extern int wakeup_pmode_return;

WARNING: externs should be avoided in .c files
#979: FILE: arch/x86/kernel/acpi/sleep.c:32:
+extern char swsusp_pg_dir[PAGE_SIZE];

WARNING: externs should be avoided in .c files
#984: FILE: arch/x86/kernel/acpi/sleep.c:37:
+extern unsigned long FASTCALL(acpi_copy_wakeup_routine(unsigned long));

total: 2 errors, 13 warnings, 1615 lines checked

/home/lenb/Documents/wakeup.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.



  reply	other threads:[~2008-02-15  6:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 22:27 Pavel Machek
2008-02-15  6:35 ` Len Brown [this message]
2008-02-15  9:55   ` Pavel Machek
2008-02-15 14:56     ` Rafael J. Wysocki
2008-02-15 22:22   ` Rafael J. Wysocki
2008-02-15 23:19     ` Len Brown
2008-02-17 23:49       ` Rafael J. Wysocki
2008-02-20  0:20         ` Rafael J. Wysocki
2008-02-15 23:30     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802150135.07127.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=sam@ravnborg.org \
    --subject='Re: [patch] move wakeup code to .c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).