LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN
@ 2008-02-15  0:56 Adrian Bunk
  2008-02-15  7:33 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-02-15  0:56 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: linux-kernel

The pattern for making a config option on purpose not available is a 
dependency on BROKEN.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
79b6f4490cadd62b3601f653df8a27ec2295adf0 diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a370fe8..9fad6da 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -81,7 +81,7 @@ config HEADERS_CHECK
 
 config DEBUG_SECTION_MISMATCH
 	bool "Enable full Section mismatch analysis"
-	depends on UNDEFINED
+	depends on BROKEN
 	help
 	  The section mismatch analysis checks if there are illegal
 	  references from one section to another section.


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN
  2008-02-15  0:56 [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN Adrian Bunk
@ 2008-02-15  7:33 ` Sam Ravnborg
  2008-02-15  7:40   ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2008-02-15  7:33 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel

On Fri, Feb 15, 2008 at 02:56:48AM +0200, Adrian Bunk wrote:
> The pattern for making a config option on purpose not available is a 
> dependency on BROKEN.
BROKEN says that what is selected by the cofig option
is broken.
This is not the case for DEBUG_SECTION_MISMATCH which is
why it was made dependent on something else.

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN
  2008-02-15  7:33 ` Sam Ravnborg
@ 2008-02-15  7:40   ` Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-02-15  7:40 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: linux-kernel

On Fri, Feb 15, 2008 at 08:33:06AM +0100, Sam Ravnborg wrote:
> On Fri, Feb 15, 2008 at 02:56:48AM +0200, Adrian Bunk wrote:
> > The pattern for making a config option on purpose not available is a 
> > dependency on BROKEN.
> BROKEN says that what is selected by the cofig option
> is broken.
> This is not the case for DEBUG_SECTION_MISMATCH which is
> why it was made dependent on something else.

BROKEN is our pattern for "intentionally disabled".

I did really grep for UNDEFINED when I first saw it since it might as 
well have been some kind of CONFIG_UNDEFINED "warn about undefined foobar".

> 	Sam

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-15  7:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-15  0:56 [2.6 patch] let DEBUG_SECTION_MISMATCH depend on BROKEN Adrian Bunk
2008-02-15  7:33 ` Sam Ravnborg
2008-02-15  7:40   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).