LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-kernel@vger.kernel.org, kkeil@suse.de,
	isdn4linux@listserv.isdn4linux.de
Subject: Re: [PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API
Date: Fri, 15 Feb 2008 14:33:48 +0100	[thread overview]
Message-ID: <20080215133348.GH1178@uranus.ravnborg.org> (raw)
In-Reply-To: <a73a5a9ab1ec204f77ff99677030b0d206c0abbb.1203031878.git.jeff@garzik.org>

On Tue, Jul 17, 2007 at 11:46:11PM -0400, Jeff Garzik wrote:
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
> ---
>  drivers/isdn/hisax/Kconfig   |    4 +-
>  drivers/isdn/hisax/Makefile  |    3 +-
>  drivers/isdn/hisax/bkm_a4t.c |  115 ++++++++++++++++++++++++++++--------------
>  drivers/isdn/hisax/config.c  |   27 ++++------
>  4 files changed, 92 insertions(+), 57 deletions(-)
> 
> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
> index 7832d8b..e7808f5 100644
> --- a/drivers/isdn/hisax/Kconfig
> +++ b/drivers/isdn/hisax/Kconfig
> @@ -286,8 +286,8 @@ config HISAX_HSTSAPHIR
>  	  settings.
>  
>  config HISAX_BKM_A4T
> -	bool "Telekom A4T card"
> -	depends on PCI && PCI_LEGACY
> +	tristate "Telekom A4T card"
> +	depends on PCI
>  	help
>  	  This enables HiSax support for the Telekom A4T card.
>  
> diff --git a/drivers/isdn/hisax/Makefile b/drivers/isdn/hisax/Makefile
> index b0b09e9..42bfc2f 100644
> --- a/drivers/isdn/hisax/Makefile
> +++ b/drivers/isdn/hisax/Makefile
> @@ -15,7 +15,9 @@ obj-$(CONFIG_HISAX_ST5481)		+= hisax_st5481.o
>  obj-$(CONFIG_HISAX_HFCUSB)		+= hfc_usb.o
>  obj-$(CONFIG_HISAX_HFC4S8S)		+= hfc4s8s_l1.o
>  obj-$(CONFIG_HISAX_FRITZ_PCIPNP)        += hisax_isac.o hisax_fcpcipnp.o
> +obj-$(CONFIG_HISAX_BKM_A4T)		+= bkm_a4t_pci.o libhisax.o
>  
> +bkm_a4t_pci-objs			:= bkm_a4t.o jade.o
Could we please use:
> +bkm_a4t_pci-y			:= bkm_a4t.o jade.o

> +static int __devinit
>  setup_bkm_a4t(struct IsdnCard *card)

One single line like you do here:

> +
> +static int __devinit a4t_pci_init_one(struct pci_dev *pdev,
> +				      const struct pci_device_id *ent)

> +
> +static struct pci_device_id a4t_pci_table[] = {
> +	{ PCI_VENDOR_ID_ZORAN, PCI_DEVICE_ID_ZORAN_36120,
> +	  PCI_VENDOR_ID_BERKOM, PCI_DEVICE_ID_BERKOM_A4T, },
> +
> +	{ }		/* terminate list */
> +};
const?

> +
> +static struct pci_driver a4t_pci_driver = {
> +	.name		= "bkm_a4t",
> +	.id_table	= a4t_pci_table,
> +	.probe		= a4t_pci_init_one,
> +	.remove		= hisax_pci_remove_one,
> +};
const?

> +module_param_named(protocol, a4t_protocol, int, 0444);
> +MODULE_PARM_DESC(protocol, "Values 0 (default) through 4. See ISDN_PTYPE_xxx in linux/isdnif.h");
> +
> +MODULE_DEVICE_TABLE(pci, a4t_pci_table);
> +MODULE_DESCRIPTION("ISDN HiSax BKM A4T PCI driver");
> +MODULE_LICENSE("GPL");

I thought this stuff belongs to top of file - not bottom.

	Sam

  reply	other threads:[~2008-02-15 13:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  3:04 [PATCH 00/14] [ISDN] HiSax hotplug conversion Jeff Garzik
2007-07-18  3:04 ` [PATCH 01/14] [ISDN] HiSax: modularize card setup Jeff Garzik
2008-02-15 13:38   ` Sam Ravnborg
2007-07-18  3:46 ` [PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API Jeff Garzik
2008-02-15 13:33   ` Sam Ravnborg [this message]
2007-07-18  3:49 ` [PATCH 05/14] [ISDN] HiSax enternow: " Jeff Garzik
2008-02-15 13:21   ` Jan Engelhardt
2007-07-18  3:54 ` [PATCH 06/14] [ISDN] HiSax hfc_pci, w6692: " Jeff Garzik
2007-07-18  3:59 ` [PATCH 07/14] [ISDN] HiSax nj_s, nj_u: " Jeff Garzik
2007-07-18  4:02 ` [PATCH 08/14] [ISDN] HiSax telespci: " Jeff Garzik
2007-07-24 12:26 ` [PATCH 11/14] [ISDN] HiSax niccy: convert to modern ISA/PNP/PCI probing Jeff Garzik
2007-08-02 12:37 ` [PATCH 13/14] [ISDN] HiSax bkm_a8: convert to PCI hotplug API Jeff Garzik
2007-10-31  5:10 ` [PATCH 03/14] [ISDN] Ready HiSax driver for modularization Jeff Garzik
2008-02-15 13:45   ` Sam Ravnborg
2007-10-31  5:11 ` [PATCH 09/14] [ISDN] HiSax avm_pci: convert to modern PCI/ISA/PNP probing Jeff Garzik
2007-10-31  5:12 ` [PATCH 10/14] [ISDN] HiSax gazel: convert to modern ISA/PCI probing Jeff Garzik
2007-10-31  5:13 ` [PATCH 12/14] [ISDN] HiSax diva: convert to modern ISA/PNP/PCI probing Jeff Garzik
2007-10-31  7:42 ` [PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[] Jeff Garzik
2008-02-15 13:37   ` Sam Ravnborg
2007-11-06 14:41 ` [PATCH 14/14] [isdn-pci] add missing file Jeff Garzik
2008-02-14 23:52 ` [PATCH 00/14] [ISDN] HiSax hotplug conversion Greg KH
2008-02-14 23:50   ` Jeff Garzik
2008-02-14 23:53 ` Jeff Garzik
2008-02-15 13:27 ` Sam Ravnborg
2008-02-15 15:13   ` Jeff Garzik
2008-02-15 19:11     ` Sam Ravnborg
2008-02-16  1:09 ` Andrew Morton
2008-02-16  4:41 [PATCH 01/14] [ISDN] HiSax: modularization prep Jeff Garzik
2007-07-18  3:46 ` [PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080215133348.GH1178@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=jeff@garzik.org \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).