LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <lenb@kernel.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>,
	hpa@zytor.com, sam@ravnborg.org
Subject: Re: [patch] move wakeup code to .c
Date: Fri, 15 Feb 2008 15:56:04 +0100	[thread overview]
Message-ID: <200802151556.05521.rjw@sisk.pl> (raw)
In-Reply-To: <20080215095544.GA4667@ucw.cz>

On Friday, 15 of February 2008, Pavel Machek wrote:
> Hi!
> 
> > scripts/checkpatch.pl
> > ERROR: do not initialise externals to 0 or NULL
> > #113: FILE: arch/x86/boot/video-mode.c:29:
> > +int do_restore = 0;    /* Screen contents changed during mode flip */
> 
> We were doing file move with minimal changes.
> 
> > ERROR: need a space before the open parenthesis '('
> > #710: FILE: arch/x86/kernel/acpi/realmode/wakemain.c:70:
> > +               while(1);
> 
> Bogus warning.
> 
> I'll fix al but this one, but could we do it as a followup patch? I'm
> currently at holidays, moving .S code into .c is rather
> good/important, and it should get testing ASAP.

I'll move the definitions into a header file.

Thanks,
Rafael

  reply	other threads:[~2008-02-15 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 22:27 Pavel Machek
2008-02-15  6:35 ` Len Brown
2008-02-15  9:55   ` Pavel Machek
2008-02-15 14:56     ` Rafael J. Wysocki [this message]
2008-02-15 22:22   ` Rafael J. Wysocki
2008-02-15 23:19     ` Len Brown
2008-02-17 23:49       ` Rafael J. Wysocki
2008-02-20  0:20         ` Rafael J. Wysocki
2008-02-15 23:30     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802151556.05521.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    --cc=sam@ravnborg.org \
    --subject='Re: [patch] move wakeup code to .c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).