LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] do_group_exit: use signal_group_exit() more consistently
@ 2008-02-15 18:02 Oleg Nesterov
  0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2008-02-15 18:02 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Roland McGrath, linux-kernel

(hopefully this patch is simple enough for 2.6.25)

do_group_exit() checks SIGNAL_GROUP_EXIT to avoid taking sighand->siglock.
Since ed5d2cac114202fe2978a9cbcab8f5032796d538 exec() doesn't set this flag,
we should use signal_group_exit().

This is not needed for correctness, but can speedup the multithreaded exec
and makes the code more consistent.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 25/kernel/exit.c~5_DO_GROUP_EXIT	2008-02-15 16:59:17.000000000 +0300
+++ 25/kernel/exit.c	2008-02-15 20:27:18.000000000 +0300
@@ -1057,12 +1057,13 @@ asmlinkage long sys_exit(int error_code)
 NORET_TYPE void
 do_group_exit(int exit_code)
 {
+	struct signal_struct *sig = current->signal;
+
 	BUG_ON(exit_code & 0x80); /* core dumps don't get here */
 
-	if (current->signal->flags & SIGNAL_GROUP_EXIT)
-		exit_code = current->signal->group_exit_code;
+	if (signal_group_exit(sig))
+		exit_code = sig->group_exit_code;
 	else if (!thread_group_empty(current)) {
-		struct signal_struct *const sig = current->signal;
 		struct sighand_struct *const sighand = current->sighand;
 		spin_lock_irq(&sighand->siglock);
 		if (signal_group_exit(sig))


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-15 17:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-15 18:02 [PATCH] do_group_exit: use signal_group_exit() more consistently Oleg Nesterov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).