LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Paul Menage <menage@google.com> To: balbir@in.ibm.com, pj@sgi.com, Pavel Emelianov <xemul@openvz.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, vatsa@linux.vnet.ibm.com, akpm@linux-foundation.org Cc: containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [RFC][PATCH 5/7] CGroup API: Use read_uint in memory controller Date: Fri, 15 Feb 2008 12:44:23 -0800 [thread overview] Message-ID: <20080215204821.433078000@menage.corp.google.com> (raw) In-Reply-To: 20080215204418.535025000@menage.corp.google.com [-- Attachment #1: memcontrol_use_res_counter_read_uint.patch --] [-- Type: text/plain, Size: 1646 bytes --] Update the memory controller to use read_uint for its limit/usage/failcnt control files, calling the new res_counter_read_uint() function. This allows the files to show up as u64 rather than string in the cgroup.api file. Signed-off-by: Paul Menage <menage@google.com> --- mm/memcontrol.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) Index: cgroupmap-2.6.24-mm1/mm/memcontrol.c =================================================================== --- cgroupmap-2.6.24-mm1.orig/mm/memcontrol.c +++ cgroupmap-2.6.24-mm1/mm/memcontrol.c @@ -922,13 +922,10 @@ int mem_cgroup_write_strategy(char *buf, return 0; } -static ssize_t mem_cgroup_read(struct cgroup *cont, - struct cftype *cft, struct file *file, - char __user *userbuf, size_t nbytes, loff_t *ppos) +static u64 mem_cgroup_read(struct cgroup *cont, struct cftype *cft) { - return res_counter_read(&mem_cgroup_from_cont(cont)->res, - cft->private, userbuf, nbytes, ppos, - NULL); + return res_counter_read_uint(&mem_cgroup_from_cont(cont)->res, + cft->private); } static ssize_t mem_cgroup_write(struct cgroup *cont, struct cftype *cft, @@ -1006,18 +1003,18 @@ static struct cftype mem_cgroup_files[] { .name = "usage_in_bytes", .private = RES_USAGE, - .read = mem_cgroup_read, + .read_uint = mem_cgroup_read, }, { .name = "limit_in_bytes", .private = RES_LIMIT, .write = mem_cgroup_write, - .read = mem_cgroup_read, + .read_uint = mem_cgroup_read, }, { .name = "failcnt", .private = RES_FAILCNT, - .read = mem_cgroup_read, + .read_uint = mem_cgroup_read, }, { .name = "force_empty", --
next prev parent reply other threads:[~2008-02-15 20:51 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-15 20:44 [RFC][PATCH 0/7] CGroup API: More structured API for CGroups control files Paul Menage 2008-02-15 20:44 ` [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file Paul Menage 2008-02-16 10:07 ` Balbir Singh 2008-02-16 17:44 ` Paul Menage 2008-02-18 9:45 ` Li Zefan 2008-02-18 10:32 ` Balbir Singh 2008-02-19 21:57 ` Paul Jackson 2008-02-20 2:51 ` Paul Menage 2008-02-20 5:17 ` Paul Jackson 2008-02-20 5:23 ` Paul Menage 2008-02-20 2:51 ` Paul Menage 2008-02-15 20:44 ` [RFC][PATCH 2/7] CGroup API: Add cgroup map data type Paul Menage 2008-02-15 20:44 ` [RFC][PATCH 3/7] CGroup API: Use cgroup map for memcontrol stats file Paul Menage 2008-02-15 20:44 ` [RFC][PATCH 4/7] CGroup API: Add res_counter_read_uint() Paul Menage 2008-02-15 20:44 ` Paul Menage [this message] 2008-02-15 20:44 ` [RFC][PATCH 6/7] CGroup API: Use descriptions for memory controller API files Paul Menage 2008-02-15 20:44 ` [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API Paul Menage 2008-02-17 3:29 ` Paul Jackson 2008-02-17 17:18 ` Paul Menage 2008-02-17 17:28 ` Paul Jackson 2008-02-17 17:48 ` Paul Menage 2008-02-18 9:55 ` Li Zefan [not found] ` <47B96805.7070002@linux.vnet.ibm.com> 2008-02-18 11:13 ` Balbir Singh 2008-02-18 11:52 ` Andreas Schwab [not found] ` <47B971C6.4080807@linux.vnet.ibm.com> 2008-02-18 11:56 ` Balbir Singh 2008-02-16 4:21 ` [RFC][PATCH 0/7] CGroup API: More structured API for CGroups control files KAMEZAWA Hiroyuki 2008-02-16 9:31 ` Li Zefan 2008-02-16 17:40 ` Paul Menage
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080215204821.433078000@menage.corp.google.com \ --to=menage@google.com \ --cc=akpm@linux-foundation.org \ --cc=balbir@in.ibm.com \ --cc=containers@lists.linux-foundation.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pj@sgi.com \ --cc=vatsa@linux.vnet.ibm.com \ --cc=xemul@openvz.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).