[2.6 patch] fs/freevxfs/: proper externs

[2.6 patch] fs/freevxfs/: proper externs

[Adrian Bunk]

This patch moves the extern declarations of several structs to vxfs_extern.h

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 fs/freevxfs/vxfs_extern.h |    5 +++++
 fs/freevxfs/vxfs_immed.c  |    1 +
 fs/freevxfs/vxfs_inode.c  |    5 -----
 3 files changed, 6 insertions(+), 5 deletions(-)

d5e4ab16e3f3550022ee77df02a0602bc03642ee diff --git a/fs/freevxfs/vxfs_extern.h b/fs/freevxfs/vxfs_extern.h
index 2b46064..50ab5ee 100644
--- a/fs/freevxfs/vxfs_extern.h
+++ b/fs/freevxfs/vxfs_extern.h
@@ -50,7 +50,11 @@ extern daddr_t			vxfs_bmap1(struct inode *, long);
 /* vxfs_fshead.c */
 extern int			vxfs_read_fshead(struct super_block *);
 
+/* vxfs_immed.c */
+extern const struct inode_operations vxfs_immed_symlink_iops;
+
 /* vxfs_inode.c */
+extern const struct address_space_operations vxfs_immed_aops;
 extern struct kmem_cache	*vxfs_inode_cachep;
 extern void			vxfs_dumpi(struct vxfs_inode_info *, ino_t);
 extern struct inode *		vxfs_get_fake_inode(struct super_block *,
@@ -69,6 +73,7 @@ extern const struct file_operations	vxfs_dir_operations;
 extern int			vxfs_read_olt(struct super_block *, u_long);
 
 /* vxfs_subr.c */
+extern const struct address_space_operations vxfs_aops;
 extern struct page *		vxfs_get_page(struct address_space *, u_long);
 extern void			vxfs_put_page(struct page *);
 extern struct buffer_head *	vxfs_bread(struct inode *, int);
diff --git a/fs/freevxfs/vxfs_immed.c b/fs/freevxfs/vxfs_immed.c
index 8a5959a..c36aeaf 100644
--- a/fs/freevxfs/vxfs_immed.c
+++ b/fs/freevxfs/vxfs_immed.c
@@ -35,6 +35,7 @@
 #include <linux/namei.h>
 
 #include "vxfs.h"
+#include "vxfs_extern.h"
 #include "vxfs_inode.h"
 
 
diff --git a/fs/freevxfs/vxfs_inode.c b/fs/freevxfs/vxfs_inode.c
index ad88d23..9f3f2ce 100644
--- a/fs/freevxfs/vxfs_inode.c
+++ b/fs/freevxfs/vxfs_inode.c
@@ -41,11 +41,6 @@
 #include "vxfs_extern.h"
 
 
-extern const struct address_space_operations vxfs_aops;
-extern const struct address_space_operations vxfs_immed_aops;
-
-extern const struct inode_operations vxfs_immed_symlink_iops;
-
 struct kmem_cache		*vxfs_inode_cachep;
 
 

Re: [2.6 patch] fs/freevxfs/: proper externs

[Christoph Hellwig]

On Sun, Feb 17, 2008 at 10:20:28AM +0200, Adrian Bunk wrote:
> This patch moves the extern declarations of several structs to vxfs_extern.h
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

ACK.

> 
> ---
> 
>  fs/freevxfs/vxfs_extern.h |    5 +++++
>  fs/freevxfs/vxfs_immed.c  |    1 +
>  fs/freevxfs/vxfs_inode.c  |    5 -----
>  3 files changed, 6 insertions(+), 5 deletions(-)
> 
> d5e4ab16e3f3550022ee77df02a0602bc03642ee diff --git a/fs/freevxfs/vxfs_extern.h b/fs/freevxfs/vxfs_extern.h
> index 2b46064..50ab5ee 100644
> --- a/fs/freevxfs/vxfs_extern.h
> +++ b/fs/freevxfs/vxfs_extern.h
> @@ -50,7 +50,11 @@ extern daddr_t			vxfs_bmap1(struct inode *, long);
>  /* vxfs_fshead.c */
>  extern int			vxfs_read_fshead(struct super_block *);
>  
> +/* vxfs_immed.c */
> +extern const struct inode_operations vxfs_immed_symlink_iops;
> +
>  /* vxfs_inode.c */
> +extern const struct address_space_operations vxfs_immed_aops;
>  extern struct kmem_cache	*vxfs_inode_cachep;
>  extern void			vxfs_dumpi(struct vxfs_inode_info *, ino_t);
>  extern struct inode *		vxfs_get_fake_inode(struct super_block *,
> @@ -69,6 +73,7 @@ extern const struct file_operations	vxfs_dir_operations;
>  extern int			vxfs_read_olt(struct super_block *, u_long);
>  
>  /* vxfs_subr.c */
> +extern const struct address_space_operations vxfs_aops;
>  extern struct page *		vxfs_get_page(struct address_space *, u_long);
>  extern void			vxfs_put_page(struct page *);
>  extern struct buffer_head *	vxfs_bread(struct inode *, int);
> diff --git a/fs/freevxfs/vxfs_immed.c b/fs/freevxfs/vxfs_immed.c
> index 8a5959a..c36aeaf 100644
> --- a/fs/freevxfs/vxfs_immed.c
> +++ b/fs/freevxfs/vxfs_immed.c
> @@ -35,6 +35,7 @@
>  #include <linux/namei.h>
>  
>  #include "vxfs.h"
> +#include "vxfs_extern.h"
>  #include "vxfs_inode.h"
>  
>  
> diff --git a/fs/freevxfs/vxfs_inode.c b/fs/freevxfs/vxfs_inode.c
> index ad88d23..9f3f2ce 100644
> --- a/fs/freevxfs/vxfs_inode.c
> +++ b/fs/freevxfs/vxfs_inode.c
> @@ -41,11 +41,6 @@
>  #include "vxfs_extern.h"
>  
>  
> -extern const struct address_space_operations vxfs_aops;
> -extern const struct address_space_operations vxfs_immed_aops;
> -
> -extern const struct inode_operations vxfs_immed_symlink_iops;
> -
>  struct kmem_cache		*vxfs_inode_cachep;
>  
>  
> 
---end quoted text---