From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755504AbYBQWci (ORCPT ); Sun, 17 Feb 2008 17:32:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753934AbYBQWc3 (ORCPT ); Sun, 17 Feb 2008 17:32:29 -0500 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:50270 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753821AbYBQWc3 (ORCPT ); Sun, 17 Feb 2008 17:32:29 -0500 Date: Sun, 17 Feb 2008 22:23:29 +0000 From: Alan Cox To: "David P. Reed" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, "David P. Reed" Subject: Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls. Message-ID: <20080217222329.1152d689@core> In-Reply-To: <6gr00g$g7cmat@smtp01.lnh.mail.rcn.net> References: <6gr00g$g7cmat@smtp01.lnh.mail.rcn.net> X-Mailer: Claws Mail 3.2.0 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 17 Feb 2008 16:56:42 -0500 (EST) "David P. Reed" wrote: > Fix pcspkr driver to use explicit timing delay for access to PIT, > rather than inb_p/outb_p calls, which use insufficiently explicit NAK. We now have inb_pit and outb_pit to make the transition easier - can you switch to those instead of coding internal knowledge outside of the kernel methods. They in turn will acquire whatever logic is needed to DTRT. Alan