LKML Archive on
help / color / mirror / Atom feed
From: Ingo Molnar <>
To: Alan Cox <>
Cc: "David P. Reed" <>,
	Thomas Gleixner <>,
	Ingo Molnar <>, "H. Peter Anvin" <>,
Subject: Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls.
Date: Mon, 18 Feb 2008 04:12:02 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20080217222329.1152d689@core>

* Alan Cox <> wrote:

> On Sun, 17 Feb 2008 16:56:42 -0500 (EST)
> "David P. Reed" <> wrote:
> > Fix pcspkr driver to use explicit timing delay for access to PIT,
> > rather than inb_p/outb_p calls, which use insufficiently explicit
> NAK.
> We now have inb_pit and outb_pit to make the transition easier - can 
> you switch to those instead of coding internal knowledge outside of 
> the kernel methods.

please also Cc: Dmitry Torokhov <> to 
drivers/input/ patches. Once inb_pit/outb_pit is used, as suggested by 
Alan, i ack the patch from the arch/x86 perspective.


      reply	other threads:[~2008-02-18  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 21:56 David P. Reed
2008-02-17 22:23 ` Alan Cox
2008-02-18  3:12   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).