LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: "Török Edwin" <edwintorok@gmail.com>
Cc: David Chinner <dgc@sgi.com>,
	Oliver Pinter <oliver.pntr@gmail.com>,
	xfs@oss.sgi.com, Linux Kernel <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Christoph Lameter <clameter@sgi.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: xfsaild causing 30+ wakeups/s on an idle system since 2.6.25-rcX
Date: Mon, 18 Feb 2008 21:21:50 +1100	[thread overview]
Message-ID: <20080218102150.GL155407@sgi.com> (raw)
In-Reply-To: <47B952D3.2030900@gmail.com>

On Mon, Feb 18, 2008 at 11:41:39AM +0200, Török Edwin wrote:
> David Chinner wrote:
> > On Sun, Feb 17, 2008 at 05:51:08PM +0100, Oliver Pinter wrote:
> >   
> >> On 2/17/08, Török Edwin <edwintorok@gmail.com> wrote:
> >>     
> >>> Hi,
> >>>
> >>> xfsaild is causing many wakeups, a quick investigation shows
> >>> xfsaild_push is always
> >>> returning 30 msecs timeout value.
> >>>       
> >
> > That's a bug
> 
> Ok. Your patches fixes the 30+ wakeups :)

Good. I'll push it out for review then.

> > , and has nothing to do with power consumption. ;)
> >   
> 
> I suggest using a sysctl value (such as
> /proc/sys/vm/dirty_writeback_centisecs), instead of a hardcoded default
> 1000.

No, too magic. I dislike adding knobs to workaround issues that
really should be fixed by having sane default behaviour.  Further
down the track as we correct know issues with the AIL push code
we'll be able to increase this idle timeout or even make it purely
wakeup driven once we get back to an idle state. However, right now
it still needs that once a second wakeup to work around a nasty
corner case that can hang the filesystem....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  reply	other threads:[~2008-02-18 10:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 16:41 Török Edwin
2008-02-17 16:51 ` Oliver Pinter
2008-02-17 22:47   ` David Chinner
2008-02-18  9:41     ` Török Edwin
2008-02-18 10:21       ` David Chinner [this message]
2008-02-18 23:22 ` Linda Walsh
2008-02-19  8:20   ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218102150.GL155407@sgi.com \
    --to=dgc@sgi.com \
    --cc=arjan@linux.intel.com \
    --cc=clameter@sgi.com \
    --cc=edwintorok@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver.pntr@gmail.com \
    --cc=xfs@oss.sgi.com \
    --subject='Re: xfsaild causing 30+ wakeups/s on an idle system since 2.6.25-rcX' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).