LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Andi Kleen <andi@firstfloor.org>, Yinghai Lu <Yinghai.Lu@Sun.COM>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <greg@kroah.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] x86: validate against acpi motherboard resources
Date: Mon, 18 Feb 2008 12:31:07 +0100	[thread overview]
Message-ID: <20080218113107.GB24147@one.firstfloor.org> (raw)
In-Reply-To: <47B67A0E.7060605@shaw.ca>

On Fri, Feb 15, 2008 at 11:52:14PM -0600, Robert Hancock wrote:
> Andi Kleen wrote:
> >Yinghai Lu <Yinghai.Lu@Sun.COM> writes:
> >>[akpm@linux-foundation.org: many fixes and cleanups]
> >>Signed-off-by: Robert Hancock <hancockr@shaw.ca>
> >>Signed-off-by: Andi Kleen <ak@suse.de>
> >>Tested-by: Andi Kleen <ak@suse.de>
> >
> >iirc it really was 
> >Tested-and-didnt-pass-test-by: Andi Kleen 
> >unfortunately. I have not rechecked recently, but on the one Intel
> >box the original patch and the other mcfg heuristics removed didn't work.
> 
> With just this patch you will have this problem. You need either the 
> patch to disable decode during BAR sizing,

Isn't that one already merged?

I remember the BAR decoding patch did help with at least one
of the original failures (there were multiple ones iirc0) 

If someone points me to all the patches needed or a tree who 
has them all applied I can give it a quick spin on the boxes I have here.
One of the systems where it originally failed I don't have anymore
though.

> or the patch to use MMCONFIG 
> for extended config space only, if you don't have them already.

That would mean it would boot, but anything that uses extended config
space would fail. While not as catastrophic as before I'm not sure
it's that great either. At least there would be still breakage,
but much more subtle ones.

-Andi

  parent reply	other threads:[~2008-02-18 10:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.LKjQjbOw482S/QFVaQ9fSrM+IFw@ifi.uio.no>
     [not found] ` <fa.wuwhrqFp6CufvpAJxShHqIaOPdI@ifi.uio.no>
2008-02-16  5:52   ` Robert Hancock
2008-02-16  6:09     ` Yinghai Lu
2008-02-17 16:42       ` Ingo Molnar
2008-02-18 11:31     ` Andi Kleen [this message]
2008-02-18 20:26       ` Robert Hancock
2008-02-15  9:27 Yinghai Lu
2008-02-15 11:11 ` Andi Kleen
2008-02-15 18:46   ` Yinghai Lu
2008-02-15 22:11   ` Yinghai Lu
2008-02-15 22:16     ` Yinghai Lu
2008-02-17 14:06 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218113107.GB24147@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH 1/5] x86: validate against acpi motherboard resources' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).