LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Ken Chen <kenneth.w.chen@intel.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, bcrl@kvack.org,
linux-aio@kvack.org
Subject: Re: [RFC: 2.6 patch] fs/block_dev.c: remove #if 0'ed code
Date: Mon, 18 Feb 2008 13:51:12 +0100 [thread overview]
Message-ID: <20080218125112.GY23197@kernel.dk> (raw)
In-Reply-To: <20080217081741.GH3848@cs181133002.pp.htv.fi>
On Sun, Feb 17 2008, Adrian Bunk wrote:
> Commit b2e895dbd80c420bfc0937c3729b4afe073b3848 #if 0'ed this code stating:
>
> <-- snip -->
>
> [PATCH] revert blockdev direct io back to 2.6.19 version
>
> Andrew Vasquez is reporting as-iosched oopses and a 65% throughput
> slowdown due to the recent special-casing of direct-io against
> blockdevs. We don't know why either of these things are occurring.
>
> The patch minimally reverts us back to the 2.6.19 code for a 2.6.20
> release.
>
> <-- snip -->
>
> It has since been dead code, and unless someone wants to revive it now
> it's time to remove it.
>
> This patch also makes bio_release_pages() static again and removes the
> ki_bio_count member from struct kiocb, reverting changes that had been
> done for this dead code.
I agree with this, if it's been sitting like that for a long time, might
as well just kill it. I've merged your patch, if no one complains it'll
go in during 2.6.25.
--
Jens Axboe
prev parent reply other threads:[~2008-02-18 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 8:17 Adrian Bunk
2008-02-18 12:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218125112.GY23197@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=bunk@kernel.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [RFC: 2.6 patch] fs/block_dev.c: remove #if 0'\''ed code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).