LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@kernel.org>
Cc: Theodore Tso <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
	sct@redhat.com, akpm@linux-foundation.org,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/jbd/journal.c: cleanups
Date: Mon, 18 Feb 2008 14:31:40 +0100	[thread overview]
Message-ID: <20080218133140.GA21635@elte.hu> (raw)
In-Reply-To: <20080218131209.GB21080@cs181133002.pp.htv.fi>


* Adrian Bunk <bunk@kernel.org> wrote:

> The following was meant 100% seriously:
> 
> This patch has been sent on:
> - 16 May 2006
> - 1 May 2006
> - 23 Apr 2006

ouch ...

i guess this explains what static code metrics already suggest:

   $ code-quality fs/ext3/ fs/ext4/
                                errors   lines of code   errors/KLOC
   fs/ext3/                        408           16055          25.4
   fs/ext4/                        394           25169          15.6

compared to:

   $ code-quality kernel/
                                errors   lines of code   errors/KLOC
   kernel/                         739           98759           7.4

and i guess our hope is now in:

   $ code-quality fs/btrfs/
                                errors   lines of code   errors/KLOC
   fs/btrfs/                       240           20556          11.6

(which hopefully will be a project done in a much more Linux-ish manner: 
open participation, the easy taking of patches, an inclusive, 
newbie-friendly contribution atmosphere, etc.)

	Ingo

ps. http://redhat.com/~mingo/x86.git/code-quality

  parent reply	other threads:[~2008-02-18 13:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17  8:19 Adrian Bunk
2008-02-18  7:04 ` Andreas Dilger
2008-02-18  7:12   ` Ingo Molnar
2008-02-18 11:49     ` Theodore Tso
2008-02-18 12:57       ` Ingo Molnar
2008-02-18 13:31         ` Theodore Tso
2008-02-18 13:55           ` Ingo Molnar
2008-02-18 13:12       ` Adrian Bunk
2008-02-18 13:28         ` Theodore Tso
2008-02-27 19:39           ` Adrian Bunk
2008-02-18 13:31         ` Ingo Molnar [this message]
2008-02-18 15:11           ` Theodore Tso
2008-02-18 16:22             ` Ingo Molnar
2008-02-27 21:20   ` [2.6 patch] unexport journal_update_superblock Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218133140.GA21635@elte.hu \
    --to=mingo@elte.hu \
    --cc=adilger@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    --cc=tytso@mit.edu \
    --subject='Re: [2.6 patch] fs/jbd/journal.c: cleanups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).