LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: "Haavard Skinnemoen" <hskinnemoen@norway.atmel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
<linux-kernel@vger.kernel.org>,
"David Brownell" <david-b@pacbell.net>, <kernel@avr32linux.org>,
"Francis Moreau" <francis.moro@gmail.com>,
"Paul Mundt" <lethal@linux-sh.org>,
"Vladimir A. Barinov" <vbarinov@ru.mvista.com>,
"Pierre Ossman" <drzeus-list@drzeus.cx>
Subject: Re: [RFC v3 4/7] dmaengine: Add slave DMA interface
Date: Mon, 18 Feb 2008 14:29:49 +0100 [thread overview]
Message-ID: <20080218142949.2c5b2810@dhcp-252-066.norway.atmel.com> (raw)
In-Reply-To: <BAE9DCEF64577A439B3A37F36F9B691C0407A37A@orsmsx418.amr.corp.intel.com>
On Fri, 15 Feb 2008 09:12:35 -0800
"Nelson, Shannon" <shannon.nelson@intel.com> wrote:
> I'll jump in here briefly - I'm okay with the direction this is going,
> but I want to be protective of ioatdma performance. As used in struct
> ioat_desc_sw, the cookie and ack elements end up very close to the end
> of a cache line and I'd like them to not get pushed out across the
> boundry. I don't think this proposal changes the layout, I'm just
> bringing up my concern.
Sure, performance is very important, and it's good to see that you're
critical about the changes I'm proposing. That said, the memory layout
doesn't change at all with this patch -- the fields that didn't go into
the generic dma descriptor were at the end of the struct to begin with.
I can add a comment saying that cookie and ack must always come first.
Any other fields that we need to be careful about?
Haavard
next prev parent reply other threads:[~2008-02-18 13:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 16:43 [RFC v3 1/7] dmaengine: Couple DMA channels to their physical DMA device Haavard Skinnemoen
2008-02-12 16:43 ` [RFC v3 2/7] dmaengine: Add dma_client parameter to device_alloc_chan_resources Haavard Skinnemoen
2008-02-12 16:43 ` [RFC v3 3/7] dmaengine: Add dma_chan_is_in_use() function Haavard Skinnemoen
2008-02-12 16:43 ` [RFC v3 4/7] dmaengine: Add slave DMA interface Haavard Skinnemoen
2008-02-12 16:43 ` [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users Haavard Skinnemoen
2008-02-12 16:43 ` [RFC v3 6/7] dmaengine: Driver for the Synopsys DesignWare DMA controller Haavard Skinnemoen
2008-02-12 16:43 ` [RFC v3 7/7] Atmel MCI: Driver for Atmel on-chip MMC controllers Haavard Skinnemoen
2008-02-12 20:43 ` [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users Olof Johansson
2008-02-12 22:13 ` Haavard Skinnemoen
2008-02-12 22:27 ` Dan Williams
2008-02-13 8:44 ` Haavard Skinnemoen
2008-02-13 7:21 ` [RFC v3 4/7] dmaengine: Add slave DMA interface Dan Williams
2008-02-13 8:03 ` Haavard Skinnemoen
2008-02-13 19:07 ` Dan Williams
2008-02-13 19:24 ` Haavard Skinnemoen
2008-02-15 9:53 ` Haavard Skinnemoen
2008-02-15 17:12 ` Nelson, Shannon
2008-02-18 13:29 ` Haavard Skinnemoen [this message]
2008-02-19 18:46 ` Nelson, Shannon
2008-02-16 20:06 ` Dan Williams
2008-02-18 13:22 ` Haavard Skinnemoen
2008-02-18 22:42 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218142949.2c5b2810@dhcp-252-066.norway.atmel.com \
--to=hskinnemoen@atmel.com \
--cc=dan.j.williams@intel.com \
--cc=david-b@pacbell.net \
--cc=drzeus-list@drzeus.cx \
--cc=francis.moro@gmail.com \
--cc=hskinnemoen@norway.atmel.com \
--cc=kernel@avr32linux.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shannon.nelson@intel.com \
--cc=vbarinov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).