LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: bjorn.helgaas@hp.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: [patch 2/3] PNP: Simplify quirk debug output
Date: Mon, 18 Feb 2008 09:34:05 -0700	[thread overview]
Message-ID: <20080218163732.122471879@ldl.fc.hp.com> (raw)
In-Reply-To: <20080218163403.364442547@ldl.fc.hp.com>

[-- Attachment #1: pnp-quirk-debug --]
[-- Type: text/plain, Size: 709 bytes --]

print_fn_descriptor_symbol() prints the address if we don't have a symbol,
so no need to print both.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Index: work6/drivers/pnp/quirks.c
===================================================================
--- work6.orig/drivers/pnp/quirks.c	2008-02-18 08:12:18.000000000 -0700
+++ work6/drivers/pnp/quirks.c	2008-02-18 08:42:43.000000000 -0700
@@ -184,8 +184,8 @@
 			quirk = pnp_fixups[i].quirk_function;
 
 #ifdef DEBUG
-			dev_dbg(&dev->dev, "calling quirk 0x%p", quirk);
-			print_fn_descriptor_symbol(": %s()\n",
+			dev_dbg(&dev->dev, "calling ");
+			print_fn_descriptor_symbol("%s()\n",
 				(unsigned long) *quirk);
 #endif
 			(*quirk)(dev);

-- 

  parent reply	other threads:[~2008-02-18 16:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 16:34 [patch 0/3] simplify initcall & " bjorn.helgaas
2008-02-18 16:34 ` [patch 1/3] Simplify initcall " bjorn.helgaas
2008-02-18 16:34 ` bjorn.helgaas [this message]
2008-02-18 16:34 ` [patch 3/3] PCI: Simplify quirk " bjorn.helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218163732.122471879@ldl.fc.hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --subject='Re: [patch 2/3] PNP: Simplify quirk debug output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).