LKML Archive on
help / color / mirror / Atom feed
From: Mark Fasheh <>
To: Joonwoo Park <>
Subject: Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization
Date: Mon, 18 Feb 2008 11:30:30 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
> default_groups was allocated with kcalloc, so initialize to NULL
> is unnecessary.

NACK - this isn't a performance critical section of code and that line makes
the array termination obvious, so I'm inclined to leave it as is.


Mark Fasheh
Principal Software Developer, Oracle

  parent reply	other threads:[~2008-02-18 19:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  9:08 [PATCH 1/2] [RESENDING] fs/dlm: " Joonwoo Park
2008-02-11  9:08 ` [PATCH 2/2] [RESENDING] fs/ocfs2: " Joonwoo Park
2008-02-11  9:08   ` [PATCH] [RESENDING] netconsole: register cmdline netconsole configs to configfs Joonwoo Park
2008-02-11 16:30     ` Matt Mackall
2008-02-18 19:30   ` Mark Fasheh [this message]
2008-02-18 22:16     ` [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).