LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: Joonwoo Park <joonwpark81@gmail.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	kurt.hackel@oracle.com
Subject: Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization
Date: Mon, 18 Feb 2008 16:16:04 -0600	[thread overview]
Message-ID: <20080218221604.GB5438@redhat.com> (raw)
In-Reply-To: <20080218193030.GX22671@ca-server1.us.oracle.com>

On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote:
> On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
> > default_groups was allocated with kcalloc, so initialize to NULL
> > is unnecessary.
> 
> NACK - this isn't a performance critical section of code and that line makes
> the array termination obvious, so I'm inclined to leave it as is.

The same nack for the same patch under fs/dlm.

Dave


      reply	other threads:[~2008-02-18 22:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  9:08 [PATCH 1/2] [RESENDING] fs/dlm: " Joonwoo Park
2008-02-11  9:08 ` [PATCH 2/2] [RESENDING] fs/ocfs2: " Joonwoo Park
2008-02-11  9:08   ` [PATCH] [RESENDING] netconsole: register cmdline netconsole configs to configfs Joonwoo Park
2008-02-11 16:30     ` Matt Mackall
2008-02-18 19:30   ` [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization Mark Fasheh
2008-02-18 22:16     ` David Teigland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218221604.GB5438@redhat.com \
    --to=teigland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=joonwpark81@gmail.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    --subject='Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).