LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: Yinghai.Lu@Sun.COM, greg@kroah.com, akpm@linux-foundation.org,
jeff@garzik.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] net: use numa_node in net_devcice->dev instead of parent
Date: Tue, 19 Feb 2008 03:41:10 -0800 (PST) [thread overview]
Message-ID: <20080219.034110.191579889.davem@davemloft.net> (raw)
In-Reply-To: <20080219112146.GC7204@elte.hu>
From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 19 Feb 2008 12:21:46 +0100
>
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
> > struct sk_buff *__netdev_alloc_skb(struct net_device *dev,
> > unsigned int length, gfp_t gfp_mask)
> > {
> > - int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1;
> > + int node = dev_to_node(&dev->dev);
>
> i think this is a fix for the networking folks. (Dave Cc:-ed)
It keeps getting NAK's because it's wrong.
The author of the patch hasn't convinced folks why this is really
necessary, and using the net_device embedded device struct is
definitely wrong here. It doesn't contain the NUMA node information,
the physical device does, and that is what the parent it.
next prev parent reply other threads:[~2008-02-19 11:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200802190311.44404.yinghai.lu@sun.com>
2008-02-19 11:13 ` [PATCH 1/8] x86_64: check MSR to get MMCONFIG for AMD Family 10h Opteron v3 Yinghai Lu
2008-02-21 1:36 ` [PATCH] x86: skip it if Fam 10h only handle bus 0 Yinghai Lu
2008-02-19 11:13 ` [PATCH 2/8] x86_64: check and enable MMCONFIG for AMD Family 10h Opteron v3 Yinghai Lu
2008-02-19 11:15 ` [PATCH 4/8] x86_64: use bus conf in NB conf fun1 to get bus range on node Yinghai Lu
2008-02-19 11:20 ` [PATCH 3/8] x86_64: get mp_bus_to_node as early v4 Yinghai Lu
2008-02-19 11:20 ` [PATCH 5/8] try parent numa_node at first before using default v2 Yinghai Lu
2008-02-19 17:54 ` Greg KH
2008-02-19 19:51 ` Yinghai Lu
2008-02-19 11:20 ` [PATCH 6/8] net: use numa_node in net_devcice->dev instead of parent Yinghai Lu
2008-02-19 11:21 ` Ingo Molnar
2008-02-19 11:41 ` David Miller [this message]
2008-02-19 19:42 ` Yinghai Lu
2008-02-19 19:47 ` Yinghai Lu
2008-02-19 22:55 ` David Miller
2008-02-19 23:10 ` Yinghai Lu
2008-02-20 6:27 ` Ingo Molnar
2008-02-20 8:33 ` Yinghai Lu
2008-02-19 11:21 ` [PATCH 7/8] x86_64: get boot_cpu_id as early for k8_scan_nodes Yinghai Lu
2008-02-19 11:21 ` [PATCH 8/8] x86_64: multi pci root bus with different io resource range Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219.034110.191579889.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yinghai.Lu@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--subject='Re: [PATCH 6/8] net: use numa_node in net_devcice->dev instead of parent' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).