LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: "Darrick J. Wong" <djwong@us.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH] adt7473: New driver for Analog Devices  ADT7473 sensor chip
Date: Tue, 19 Feb 2008 10:53:17 +0100	[thread overview]
Message-ID: <20080219105317.11c22ca9@hyperion.delvare> (raw)
In-Reply-To: <20080217200250.GD2916@jupiter.solarsys.private>

On Sun, 17 Feb 2008 15:02:50 -0500, Mark M. Hoffman wrote:
> * Darrick J. Wong <djwong@us.ibm.com> [2007-12-19 15:14:38 -0800]:
> > +static int adt7473_attach_adapter(struct i2c_adapter *adapter)
> > +{
> > +	/*
> > +	 * Some NVIDIA cards have an adt7473 attached to the on-board
> > +	 * i2c controller, but the i2c adapter driver in the binary
> > +	 * nvidia superblob driver sets class to 0.
> > +	 */
> > +	if (!(adapter->class & I2C_CLASS_HWMON) && adapter->class)
> > +		return 0;
> 
> NACK on that comment and associated code:  Jean Delvare submitted a
> patch to NVIDIA over two years ago to fix their bug.  Apparently some
> distros even carry his patch.  So, I don't want to encourage such a
> hack to persist.  Please just do the standard check here.

For the records: this patch exists but I did not send it to nVidia. For
legal/license reasons I do not want to be considered a contributor to
the nvidia Linux driver. So someone else will have to send the patch to
nVidia. I would hope that this was already done by now, but maybe not.

-- 
Jean Delvare

      parent reply	other threads:[~2008-02-19 10:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-19  3:41 Darrick J. Wong
     [not found] ` <20071219154759.7be5025c@hyperion.delvare>
2007-12-19 23:14   ` Darrick J. Wong
2008-02-17 20:02     ` [lm-sensors] " Mark M. Hoffman
2008-02-18 21:32       ` Darrick J. Wong
2008-02-19  9:52         ` Jean Delvare
2008-02-18 21:33       ` [PATCH v2] " Darrick J. Wong
2008-02-19  3:06         ` [lm-sensors] " Mark M. Hoffman
2008-02-19  9:53       ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080219105317.11c22ca9@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=djwong@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    --subject='Re: [PATCH] adt7473: New driver for Analog Devices  ADT7473 sensor chip' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).