LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Karl Dahlke <eklhad@comcast.net>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] export getledstate()
Date: Tue, 19 Feb 2008 11:45:15 -0800	[thread overview]
Message-ID: <20080219114515.337c9452.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080119135723.eklhad@comcast.net>

On Tue, 19 Feb 2008 13:57:23 -0500 Karl Dahlke wrote:

> I write adapters for disabled people, and we often have to do
> specialized functions based on keystrokes and key chords.
> I would like to do certain things when keys are hit and num lock is on,
> but there is no easy way to get the led state.
> There is a nice function getledstate()
> in keyboard.c, it just isn't exported.
> Here is the patch that would do that.
> Can you apply this patch, or, is there another easy way to get this information,
> or, would it be better to fold this information into keyboard_notifier_param,
> along with shift state etc.
> I use notifiers, so this would be natural, and almost as easy.
> I'd be happy to write that patch, if you think that would be a superior design.

cc Dmitry added.

I don't oppose the export, but it seems that using getledstate()
asynchronously could return out-of-sync info, while adding this info
to the notifier data would synchronize the info..
Maybe it depends on how it's done.

> 
> --- drivers/char/keyboard.c	2008-02-18 21:05:23.000000000 -0500
> +++ drivers/char/keyboard.c.new	2008-02-18 21:06:34.000000000 -0500

--- linux/drivers/char/keyboard.c.old
+++ linux/drivers/char/keyboard.c

is the preferred form.  (a) keep the top-level linux dir name.
(b) the +++ line has the correct file name.

> @@ -963,6 +963,7 @@ unsigned char getledstate(void)
>  {
>  	return ledstate;
>  }
> +EXPORT_SYMBOL_GPL(getledstate);
>  
>  void setledstate(struct kbd_struct *kbd, unsigned int led)
>  {


---
~Randy

      reply	other threads:[~2008-02-19 19:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 18:57 Karl Dahlke
2008-02-19 19:45 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080219114515.337c9452.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eklhad@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] export getledstate()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).