LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
lguest@ozlabs.org
Subject: Re: [PATCH] Fix building lguest as module.
Date: Tue, 19 Feb 2008 14:54:01 +0100 [thread overview]
Message-ID: <20080219135401.GA9192@elte.hu> (raw)
In-Reply-To: <20080219073205.GA12375@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > +#endif
> > +
> > +#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
> > + BLANK();
>
> hm. Rusty's original fix is now upstream. I've done a delta to your
> patch, find the fix is below.
the right one is below. There's no 'LGUEST_MODULE' anymore -
'LGUEST_GUEST' is what should be used.
Ingo
------------------->
Subject: lguest: fix build breakage
From: Tony Breeds <tony@bakeyournoodle.com>
Date: Tue Feb 19 08:16:03 CET 2008
[ mingo@elte.hu: merged to Rusty's patch ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/asm-offsets_32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-x86.q/arch/x86/kernel/asm-offsets_32.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/asm-offsets_32.c
+++ linux-x86.q/arch/x86/kernel/asm-offsets_32.c
@@ -128,7 +128,7 @@ void foo(void)
OFFSET(XEN_vcpu_info_pending, vcpu_info, evtchn_upcall_pending);
#endif
-#ifdef CONFIG_LGUEST_GUEST
+#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_GUEST)
BLANK();
OFFSET(LGUEST_DATA_irq_enabled, lguest_data, irq_enabled);
OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
next prev parent reply other threads:[~2008-02-19 13:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 12:45 [build bug] lguest build failure: drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference to `LGUEST_PAGES_regs_trapnum' Ingo Molnar
2008-02-01 17:05 ` Ingo Molnar
2008-02-02 12:25 ` Rusty Russell
2008-02-03 20:11 ` Rusty Russell
2008-02-17 13:51 ` Thomas Gleixner
2008-02-17 14:07 ` Sergio Luis
2008-02-17 20:11 ` Christian Kujau
2008-02-18 1:04 ` Sergio Luis
2008-02-18 1:31 ` Sergio Luis
2008-02-18 22:14 ` Christian Kujau
2008-02-18 22:19 ` Sergio Luis
2008-02-19 21:20 ` Christian Kujau
2008-02-19 3:44 ` [PATCH] Fix building lguest as module Tony Breeds
2008-02-19 7:32 ` Ingo Molnar
2008-02-19 13:54 ` Ingo Molnar [this message]
2008-02-19 23:35 ` Tony Breeds
2008-02-20 9:33 ` Ingo Molnar
2008-02-20 10:01 ` Ingo Molnar
2008-02-22 5:58 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219135401.GA9192@elte.hu \
--to=mingo@elte.hu \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tony@bakeyournoodle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).