LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: Adam Litke <>
Cc: Andy Whitcroft <>,
	Nishanth Aravamudan <>,
	William Irwin <>,,
Subject: Re: [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy
Date: Tue, 19 Feb 2008 15:30:37 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1203446512.11987.36.camel@localhost.localdomain>

On Tue, 19 Feb 2008 12:41:51 -0600 Adam Litke <> wrote:

> Indeed.  I'll take credit for this thinko...
> On Tue, 2008-02-19 at 18:28 +0000, Andy Whitcroft wrote:
> > When we free a page via free_huge_page and we detect that we are in
> > surplus the page will be returned to the buddy.  After this we no longer
> > own the page.  However at the end free_huge_page we clear out our mapping
> > pointer from page private.  Even where the page is not a surplus we
> > free the page to the hugepage pool, drop the pool locks and then clear
> > page private.  In either case the page may have been reallocated.  BAD.
> > 
> > Make sure we clear out page private before we free the page.
> > 
> > Signed-off-by: Andy Whitcroft <>
> Acked-by: Adam Litke <>

Was I right to assume that this is also needed in 2.6.24.x?

  reply	other threads:[~2008-02-19 23:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 18:28 Andy Whitcroft
2008-02-19 18:41 ` Adam Litke
2008-02-19 23:30   ` Andrew Morton [this message]
2008-02-20 14:59     ` Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).