LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* ipwireless_network_packet_received(): inconsequent NULL checking
@ 2008-02-19 19:29 Adrian Bunk
  0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2008-02-19 19:29 UTC (permalink / raw)
  To: David Sterba, jkosina; +Cc: Jiri Slaby, linux-kernel

The Coverity checker spotted the following inconsequent NULL checking in 
drivers/char/pcmcia/ipwireless/network.c:

<--  snip  -->

void ipwireless_network_packet_received(struct ipw_network *network,
                                        unsigned int channel_idx,
                                        unsigned char *data,
                                        unsigned int length)
{
...
                /*
                 * If it's associated with a tty (other than the RAS channel
                 * when we're online), then send the data to that tty. The RAS
                 * channel's data is handled above - it always goes through
                 * ppp_generic.
                 */
                if (tty && channel_idx == IPW_CHANNEL_RAS
                                && (network->ras_control_lines &
                                        IPW_CONTROL_LINE_DCD) != 0
                                && ipwireless_tty_is_modem(tty)) {
...
                /* Otherwise we send it out the tty. */
                else
                        ipwireless_tty_received(tty, data, length);
...

<--  snip  -->

ipwireless_tty_received() dereferences "tty".

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-19 19:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-19 19:29 ipwireless_network_packet_received(): inconsequent NULL checking Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).