LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dlm: match signedness between dlm_config_info and cluster_set
@ 2008-02-14  0:54 Harvey Harrison
  2008-02-19 19:47 ` David Teigland
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-14  0:54 UTC (permalink / raw)
  To: Patrick Caulfield, David Teigland, Andrew Morton; +Cc: LKML

cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
access functions.  Make the signedness match to avoid sparse warnings every time
CLUSTER_ATTR is used (lines 149-159) all of the form:

fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
fs/dlm/config.c:149:1:    expected unsigned int *info_field
fs/dlm/config.c:149:1:    got int extern [toplevel] *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 fs/dlm/config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/dlm/config.c b/fs/dlm/config.c
index c3ad1df..7ceaea3 100644
--- a/fs/dlm/config.c
+++ b/fs/dlm/config.c
@@ -114,7 +114,7 @@ struct cluster_attribute {
 };
 
 static ssize_t cluster_set(struct cluster *cl, unsigned int *cl_field,
-			   unsigned int *info_field, int check_zero,
+			   int *info_field, int check_zero,
 			   const char *buf, size_t len)
 {
 	unsigned int x;
-- 
1.5.4.1.1278.gc75be




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] dlm: match signedness between dlm_config_info and cluster_set
  2008-02-14  0:54 [PATCH] dlm: match signedness between dlm_config_info and cluster_set Harvey Harrison
@ 2008-02-19 19:47 ` David Teigland
  0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2008-02-19 19:47 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Patrick Caulfield, Andrew Morton, LKML

On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote:
> cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
> access functions.  Make the signedness match to avoid sparse warnings every time
> CLUSTER_ATTR is used (lines 149-159) all of the form:
> 
> fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
> fs/dlm/config.c:149:1:    expected unsigned int *info_field
> fs/dlm/config.c:149:1:    got int extern [toplevel] *<noident>
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Thanks, added to dlm.git.
Dave


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-19 19:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-14  0:54 [PATCH] dlm: match signedness between dlm_config_info and cluster_set Harvey Harrison
2008-02-19 19:47 ` David Teigland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).